From: Christoph Hellwig <hch@infradead.org>
To: Tal Zussman <tz2294@columbia.edu>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH] syscalls: Fix file comments for syscalls implemented in kernel/sys.c
Date: Mon, 16 Nov 2020 16:23:11 +0000 [thread overview]
Message-ID: <20201116162311.GA15585@infradead.org> (raw)
In-Reply-To: <20201112215657.GA4539@charmander>
On Thu, Nov 12, 2020 at 04:56:57PM -0500, Tal Zussman wrote:
> The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c,
> but the comments weren't updated to reflect this change.
>
> Fixing these comments messes up the alphabetical ordering of syscalls by
> filename. This could be fixed by merging the two groups of kernel/sys.c syscalls,
> but that would require reordering the syscalls and renumbering them to maintain
> the numerical order in unistd.h.
Lots of overly long lines in your commit log.
As for the patch itself: IMHO we should just remove the comments
about the files as that information is completely irrelevant.
next prev parent reply other threads:[~2020-11-16 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 21:56 [PATCH] syscalls: Fix file comments for syscalls implemented in kernel/sys.c Tal Zussman
2020-11-16 16:23 ` Christoph Hellwig [this message]
2020-11-16 16:44 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116162311.GA15585@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).