From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB124C64E7A for ; Fri, 20 Nov 2020 09:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BE9D2224C for ; Fri, 20 Nov 2020 09:13:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TTIb8ohQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727262AbgKTJNE (ORCPT ); Fri, 20 Nov 2020 04:13:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgKTJND (ORCPT ); Fri, 20 Nov 2020 04:13:03 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E24C0613CF; Fri, 20 Nov 2020 01:13:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mNLnU8cl44VoAwmtF3N/cVr4YIhMWVFWr0ATljQRTes=; b=TTIb8ohQ+PwDq74N++0bgk2zll V4Tj1uTEh1nLpZA5CWmWqyId5ggC5fFNgj0pboCtHDqY3L67GCyZNuDKPhIyDglg/E86QFfp03+bI wGOy+rZdGneSYckkAgLWS4Lquu6jKns1/3RDzJtgxPXaG/cApFOXbxrjmFwxID+CMkn8bfg2ariPD q8PRJnZIyL/pF1pJzmkrZOIsiNWxi9EqbnrSKptOWKTutDymxTvJ3MTHzpDBEzdVC/iFZdmds1m9/ d0Edw6QH1c1pHG3bkB/sYhvaimIvfkENpPeia3BDp903NdAOst0DSmCRA3GxWKsouD7etMiOrv1DU Mvs7rk4A==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg2TH-0003xV-Ap; Fri, 20 Nov 2020 09:12:47 +0000 Date: Fri, 20 Nov 2020 09:12:47 +0000 From: Christoph Hellwig To: Christian Brauner Cc: "Darrick J. Wong" , Alexander Viro , Christoph Hellwig , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Jann Horn , Seth Forshee , St??phane Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-audit@redhat.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v2 00/39] fs: idmapped mounts Message-ID: <20201120091247.GA14894@infradead.org> References: <20201115103718.298186-1-christian.brauner@ubuntu.com> <20201120023309.GH9685@magnolia> <20201120091044.ofkzgiwoyru23vc4@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201120091044.ofkzgiwoyru23vc4@wittgenstein> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Fri, Nov 20, 2020 at 10:10:44AM +0100, Christian Brauner wrote: > Maybe you didn't see this or you're referring to xfstests but this > series contains a >=4000 lines long test-suite that validates all core > features with and without idmapped mounts. It's the last patch in this > version of the series and it's located in: > tools/testing/selftests/idmap_mounts. > > Everytime a filesystem is added this test-suite will be updated. We > would perfer if this test would be shipped with the kernel itself and > not in a separate test-suite such as xfstests. But we're happy to add > patches for the latter at some point too. selftests is a complete pain to use, partialy because it is not integrated with the framework we file system developers use (xfstests) and partially because having the test suite in the kernel tree really breaks a lot of the typical use cases. So I think we'll need to wire this up in the proper place instead.