Re: [PATCH v3 33/38] ext4: support idmapped mounts

Christian Brauner
2020-12-01T11:15:24Z

On Tue, Dec 01, 2020 at 12:13:20PM +0100, Christoph Hellwig wrote:
> On Tue, Dec 01, 2020 at 12:02:19PM +0100, Christian Brauner wrote:
> > On Tue, Dec 01, 2020 at 11:54:45AM +0100, Christoph Hellwig wrote:
> > > What is the reason for the config option? The only thing that it
> > > controls is setting of a single flag.
> >
> > I wanted to be conservative and give users the option to disable this on
> > their kernel. Would you prefer if I drop it?
>
> I don't think adding an option per file system scales in any way. If
> there is some strong urge to disable the functionality (which I see no
> reason for) we could add something like a global sysctl for all on-disk
> file systems.

Sounds reasonable. I'm dropping the config options.

Christian