From: Oscar Salvador <osalvador@suse.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH] mm,hwpoison: Return -EBUSY when migration fails
Date: Wed, 9 Dec 2020 11:38:21 +0100 [thread overview]
Message-ID: <20201209103821.GE30892@linux> (raw)
In-Reply-To: <ae1f9209-f4f7-fae5-1d8f-5e7e5d2d55aa@suse.cz>
On Wed, Dec 09, 2020 at 11:25:31AM +0100, Vlastimil Babka wrote:
> On 12/9/20 10:28 AM, Oscar Salvador wrote:
> > Currently, we return -EIO when we fail to migrate the page.
> >
> > Migrations' failures are rather transient as they can happen due to
> > several reasons, e.g: high page refcount bump, mapping->migrate_page
> > failing etc.
> > All meaning that at that time the page could not be migrated, but
> > that has nothing to do with an EIO error.
> >
> > Let us return -EBUSY instead, as we do in case we failed to isolate
> > the page.
> >
> > While are it, let us remove the "ret" print as its value does not change.
> >
> > Signed-off-by: Oscar Salvador <osalvador@suse.de>
>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> Technically this affects madvise(2) so let's cc linux-api. The manpage doesn't
> document error codes of MADV_HWPOISON and MADV_SOFT_OFFLINE (besides EPERM)
> though so nothing to adjust there. It's meant only for the hwpoison testing
> suite anyway.
Well, not only for hwpoison testing suite.
RAS/CEC and GHES also use soft_offline_page by means of memory_failure_queue
in case a page cec count goes beyond a certain thereshold, but they do not
really check the return code.
Only madvise does.
--
Oscar Salvador
SUSE L3
prev parent reply other threads:[~2020-12-09 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201209092818.30417-1-osalvador@suse.de>
2020-12-09 10:25 ` [PATCH] mm,hwpoison: Return -EBUSY when migration fails Vlastimil Babka
2020-12-09 10:38 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209103821.GE30892@linux \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).