From: "Dmitry V. Levin" <ldv@altlinux.org>
To: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Cc: Willem de Bruijn <willemb@google.com>,
linux-man <linux-man@vger.kernel.org>,
Florian Weimer <fweimer@redhat.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: epoll_wait.2: epoll_pwait2(2) prototype
Date: Sat, 13 Mar 2021 20:02:50 +0300 [thread overview]
Message-ID: <20210313170250.GA15968@altlinux.org> (raw)
In-Reply-To: <eb42faba-2235-4536-df49-795ef2719552@gmail.com>
Hi Alex,
On Sat, Mar 13, 2021 at 05:48:08PM +0100, Alejandro Colomar (man-pages) wrote:
> Hi Willem,
>
> I checked that the prototype of the kernel epoll_pwait2() syscall is
> different from the one we recently merged; it has one more parameter
> 'size_t sigsetsize':
>
> $ grep_syscall epoll_pwait2
> fs/eventpoll.c:2272:
> SYSCALL_DEFINE6(epoll_pwait2, int, epfd, struct epoll_event __user *,
> events,
> int, maxevents, const struct __kernel_timespec __user *, timeout,
> const sigset_t __user *, sigmask, size_t, sigsetsize)
> fs/eventpoll.c:2326:
> COMPAT_SYSCALL_DEFINE6(epoll_pwait2, int, epfd,
> struct epoll_event __user *, events,
> int, maxevents,
> const struct __kernel_timespec __user *, timeout,
> const compat_sigset_t __user *, sigmask,
> compat_size_t, sigsetsize)
> include/linux/compat.h:540:
> asmlinkage long compat_sys_epoll_pwait2(int epfd,
> struct epoll_event __user *events,
> int maxevents,
> const struct __kernel_timespec __user *timeout,
> const compat_sigset_t __user *sigmask,
> compat_size_t sigsetsize);
> include/linux/syscalls.h:389:
> asmlinkage long sys_epoll_pwait2(int epfd, struct epoll_event __user
> *events,
> int maxevents,
> const struct __kernel_timespec __user *timeout,
> const sigset_t __user *sigmask,
> size_t sigsetsize);
>
> I'm could fix the prototype, but maybe there are more changes needed for
> the manual page.
>
> Would you mind fixing it?
Looks like the 6th argument of epoll_pwait and epoll_pwait2 syscalls
is already described in "C library/kernel differences" subsection of
epoll_pwait2(2).
--
ldv
next prev parent reply other threads:[~2021-03-13 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 16:48 epoll_wait.2: epoll_pwait2(2) prototype Alejandro Colomar (man-pages)
2021-03-13 17:02 ` Dmitry V. Levin [this message]
2021-03-13 17:10 ` Alejandro Colomar (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313170250.GA15968@altlinux.org \
--to=ldv@altlinux.org \
--cc=alx.manpages@gmail.com \
--cc=fweimer@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).