From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885C7C433ED for ; Tue, 27 Apr 2021 20:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 691C3613D8 for ; Tue, 27 Apr 2021 20:42:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237009AbhD0Unm (ORCPT ); Tue, 27 Apr 2021 16:43:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44851 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236058AbhD0Unk (ORCPT ); Tue, 27 Apr 2021 16:43:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619556176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/RvrYyTMEiHtCZW0MwDUjdnqhLrqE4kTWBWaQVaWhX4=; b=WQGQrE8005hQuJPgNBTVb9M+k4OOVGS2YS4VFlpdoTu5s0kcX1qoN1y26UOo0qS0aIxDC1 BsTN9QOq0y/TGxvA0VNKwPnBq2n2bOp6Bpcn3xtWIe1LS/5PL4tc2lOMYhmyYafiY4h9mX KhENcy8kamva3NQe8v9W5NiGrMSCYAQ= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-528-IkneA2j_PjeA05ZGfOOPkw-1; Tue, 27 Apr 2021 16:42:53 -0400 X-MC-Unique: IkneA2j_PjeA05ZGfOOPkw-1 Received: by mail-qk1-f198.google.com with SMTP id e4-20020a37b5040000b02902df9a0070efso23899128qkf.18 for ; Tue, 27 Apr 2021 13:42:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/RvrYyTMEiHtCZW0MwDUjdnqhLrqE4kTWBWaQVaWhX4=; b=tJ+50fOHJltNUyd+w5Q8qB94J7U8SQEMvf3CQui/OX7W1T9U8eUs6vAWCAe3OY7zr3 y4Lvp4mLpTgmvdeGNsE9K/MAMKoWUqS5e04dpl2OfbKK3yC28t6g7HtX0gn6r5nyFDIl 0N3dfkfDeELFvVT26ERJB2O0pvAiy7w/ovKhImgiKyDc86GOq+KnXexBRFZZXTFc80ST 9yLlYzWgEZln6sgmj0mCezDv9mwi+AaddCTVWdAJwzEKflUPMAFp2nQrdnDwl8kjnKtp os9EVK+qCVO0csqW4GCF+iKHfLthhGfIzlvVyTxtxXzLBeltUInrVCglvaAdUpM6tyTL mNGQ== X-Gm-Message-State: AOAM533lJSRj9WtHXbY7UlNFXkmddS5iX/CdWVmdGi4erYYDxD4Vt8zr p4DfB5N1BVXm+SQ9w2qhyPs3uVQfwSbBBeLsXhSoatsnxkyC8OOUqaWX5jHo6Eh7mmDkoZlcORD /zPuhLFVyQVKU/FlyhU1f X-Received: by 2002:a05:622a:11d1:: with SMTP id n17mr10557604qtk.360.1619556172935; Tue, 27 Apr 2021 13:42:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXdbR54zw+S/1LpL+C8ZvobC9U+08rm/wphtfr+XZ5o9lHGt3slPtEst+FHJjmjSso+DRu0w== X-Received: by 2002:a05:622a:11d1:: with SMTP id n17mr10557577qtk.360.1619556172652; Tue, 27 Apr 2021 13:42:52 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-77-184-145-104-227.dsl.bell.ca. [184.145.104.227]) by smtp.gmail.com with ESMTPSA id u126sm3664993qkd.80.2021.04.27.13.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 13:42:51 -0700 (PDT) Date: Tue, 27 Apr 2021 16:42:50 -0400 From: Peter Xu To: Axel Rasmussen Cc: Hugh Dickins , Alexander Viro , Andrea Arcangeli , Andrew Morton , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, LKML , linux-kselftest@vger.kernel.org, Linux MM , Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH v4 03/10] userfaultfd/shmem: support UFFDIO_CONTINUE for shmem Message-ID: <20210427204250.GG6820@xz-x1> References: <20210420220804.486803-1-axelrasmussen@google.com> <20210420220804.486803-4-axelrasmussen@google.com> <20210427155414.GB6820@xz-x1> <20210427180314.GD6820@xz-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Tue, Apr 27, 2021 at 01:29:14PM -0700, Axel Rasmussen wrote: > On Tue, Apr 27, 2021 at 11:03 AM Peter Xu wrote: > > > > On Tue, Apr 27, 2021 at 09:57:16AM -0700, Axel Rasmussen wrote: > > > I'd prefer to keep them separate, as they are not tiny patches (they > > > are roughly +200/-150 each). And, they really are quite independent - > > > at least in the sense that I can reorder them via rebase with no > > > conflicts, and the code builds at each commit in either orientation. I > > > think this implies they're easier to review separately, rather than > > > squashed. > > > > > > I don't have a strong feeling about the order. I slightly prefer > > > swapping them compared to this v4 series: first introduce minor > > > faults, then introduce CONTINUE. > > > > > > Since Peter also has no strong opinion, and Hugh it sounds like you > > > prefer it the other way around, I'll swap them as we had in some > > > previous version of this series: first introduce minor faults, then > > > introduce CONTINUE. > > > > Yes I have no strong opinion, but that's probably the least I prefer. :-) > > > > Because you'll declare UFFD_FEATURE_MINOR_SHMEM and enable this feature without > > the feature being completely implemented (without UFFDIO_CONTINUE, it's not > > complete since no one will be able to resolve that minor fault). > > > > Not a big deal anyway, but since we're at it... Basically I think three things > > to do for minor shmem support: > > > > (1) UFFDIO_CONTINUE (resolving path) > > (2) Handle fault path for shmem minor fault (faulting path) > > (3) Enablement of UFFD_FEATURE_MINOR_SHMEM (from which point, user can detect > > and enable it) > > > > I have no preference on how you'd like to merge these steps (right now you did > > 1 first, then 2+3 later; or as Hugh suggested do 1+2+3 together), but I'd still > > hope item 3 should always be the last, if possible... > > In that case, I'll split the patch which adds the faulting path in > two: add the faulting path hook and registration mode, and then in a > separate commit advertise the feature flag as available. > > Then I'll order them like so, which I think is the order Hugh finds > more natural: > 1. MInor fault registration / faulting path > 2. CONTINUE ioctl to resolve the faults > 3. Advertise the feature as supported > > Sound okay? Good to me, thanks Axel. -- Peter Xu