From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2E7C48BE5 for ; Tue, 15 Jun 2021 11:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A9BB6145B for ; Tue, 15 Jun 2021 11:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbhFOLgP (ORCPT ); Tue, 15 Jun 2021 07:36:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbhFOLgP (ORCPT ); Tue, 15 Jun 2021 07:36:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EC54461107; Tue, 15 Jun 2021 11:34:08 +0000 (UTC) Date: Tue, 15 Jun 2021 13:34:05 +0200 From: Christian Brauner To: Matthew Bobrowski Cc: jack@suse.cz, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v2 1/5] kernel/pid.c: remove static qualifier from pidfd_create() Message-ID: <20210615113405.ytf2u23qmzaoq4yl@wittgenstein> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Thu, Jun 10, 2021 at 10:20:06AM +1000, Matthew Bobrowski wrote: > With the idea of returning pidfds from the fanotify API, we need to > expose a mechanism for creating pidfds. We drop the static qualifier > from pidfd_create() and add its declaration to linux/pid.h so that the > pidfd_create() helper can be called from other kernel subsystems > i.e. fanotify. > > Signed-off-by: Matthew Bobrowski > --- Looks good, Acked-by: Christian Brauner