[PATCH] corrent sys_reboot annotation

[PATCH] corrent sys_reboot annotation

[Wang Zi-cheng]

Signed-off-by: Wang Zi-cheng <wzc@smail.nju.edu.cn>
---
 include/linux/syscalls.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 586128d5c3b8..68746eec0092 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -735,11 +735,14 @@ asmlinkage long sys_rt_sigtimedwait_time32(const sigset_t __user *uthese,
 				size_t sigsetsize);
 asmlinkage long sys_rt_sigqueueinfo(pid_t pid, int sig, siginfo_t __user *uinfo);
 
+/* kernel/reboot.c */
+asmlinkage long sys_reboot(int magic1, int magic2, unsigned int cmd,
+				void __user *arg);
+
 /* kernel/sys.c */
 asmlinkage long sys_setpriority(int which, int who, int niceval);
 asmlinkage long sys_getpriority(int which, int who);
-asmlinkage long sys_reboot(int magic1, int magic2, unsigned int cmd,
-				void __user *arg);
+
 asmlinkage long sys_setregid(gid_t rgid, gid_t egid);
 asmlinkage long sys_setgid(gid_t gid);
 asmlinkage long sys_setreuid(uid_t ruid, uid_t euid);
-- 
2.32.0

--------------

sys_reboot is in kernel/reboot.c not kernel/sys.c  

Re: [PATCH] corrent sys_reboot annotation

[Greg KH]

On Fri, Jul 30, 2021 at 02:40:32PM +0800, Wang Zi-cheng wrote:
> Signed-off-by: Wang Zi-cheng <wzc@smail.nju.edu.cn>

You forgot a changelog text :(

Re: [PATCH] corrent sys_reboot annotation

[Greg KH]

On Fri, Jul 30, 2021 at 03:00:47PM +0800, Zicheng Wang wrote:
> 
> 在 2021/7/30 14:54, Greg KH 写道:
> > On Fri, Jul 30, 2021 at 02:40:32PM +0800, Wang Zi-cheng wrote:
> > > Signed-off-by: Wang Zi-cheng <wzc@smail.nju.edu.cn>
> > You forgot a changelog text :(
> 
> 
> Sorry, and what should I write for a changelog?

You tell me, you are the one that determined this needed a change, not
me :)

Also, your subject is odd and needs to be fixed, please see the
documentation for how to write good kernel changelogs and subject lines.

Also, when starting out, I would recommend working in the
drivers/staging/ part of the kernel until you learn these basic skills
as that is the part of the kernel best for that.

thanks,

greg k-h