From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7067BC432BE for ; Thu, 2 Sep 2021 13:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4515C6108B for ; Thu, 2 Sep 2021 13:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234354AbhIBNgv (ORCPT ); Thu, 2 Sep 2021 09:36:51 -0400 Received: from mx20.baidu.com ([111.202.115.85]:53226 "EHLO baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234350AbhIBNgu (ORCPT ); Thu, 2 Sep 2021 09:36:50 -0400 Received: from Bc-Mail-Ex13.internal.baidu.com (unknown [172.31.51.53]) by Forcepoint Email with ESMTPS id 7AFDD116EDC554C40873; Thu, 2 Sep 2021 21:35:30 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by Bc-Mail-Ex13.internal.baidu.com (172.31.51.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Thu, 2 Sep 2021 21:35:30 +0800 Received: from localhost (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 2 Sep 2021 21:35:30 +0800 Date: Thu, 2 Sep 2021 21:35:29 +0800 From: Cai Huoqing To: Steve Grubb CC: , strace development discussions , , , , , , , , Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Message-ID: <20210902133529.GA32500@LAPTOP-UKSR4ENP.internal.baidu.com> Reply-To: q@vger.kernel.org References: <20210813120803.101-1-caihuoqing@baidu.com> <20210901160244.GA5957@asgard.redhat.com> <20210901165202.GA4518@asgard.redhat.com> <1797920.tdWV9SEqCh@x2> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1797920.tdWV9SEqCh@x2> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BJHW-Mail-Ex16.internal.baidu.com (10.127.64.39) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 01 Sep 21 13:36:54, Steve Grubb wrote: > Hello, > > Thanks for the heads up. > > On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote: > > Adding linux-audit, strace-devel, and linux-api to CC:. > > > > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote: > > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > > > > commit <47595e32869f> ("") > > > > indicated the ipx network layer as obsolete in Jan 2018, > > > > updated in the MAINTAINERS file > > > > > > > > now, after being exposed for 3 years to refactoring, so to > > > > delete uapi/linux/ipx.h and net/ipx.h header files for good. > > > > additionally, there is no module that depends on ipx.h except > > > > a broken staging driver(r8188eu) > > > > > > > > Signed-off-by: Cai Huoqing > > > > > > This removal breaks audit[1] and potentially breaks strace[2][3], at > > > least. > > I wouldn't say breaks so much as needs coordination with. :-) If ipx is > being dropped in its entirety, I can just make that part of the code > conditional to the header existing. > > -Steve IPX is marked obsolete for serveral years. so remove it and the dependency in linux tree. I'm sorry to not thinking about linux-audit and strace. Might you remove the dependency or make the part of the code. Many thanks. -Cai > > > > [1] > > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1 > > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2] > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > > d7106d6b/src/net.c#L34 [3] > > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > > d7106d6b/src/sockaddr.c#L30 > > > >