Re: [PATCH v4 2/6] fs: change ki_complete interface to support 64bit ret2

Christoph Hellwig
2020-07-26T15:18:28Z

On Fri, Jul 24, 2020 at 09:19:18PM +0530, Kanchan Joshi wrote:
> From: SelvaKumar S <selvakuma.s1@samsung.com>
>
> kiocb->ki_complete(...,long ret2) - change ret2 to long long.
> This becomes handy to return 64bit written-offset with appending write.
> Change callers using ki_complete prototype.

There is no need for this at all. By the time ki_complete is called
ki_pos contains the new offset, and you just have to subtract res from
that.