From: kernel test robot <lkp@intel.com>
To: Zach O'Keefe <zokeefe@google.com>, linux-mm@kvack.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-api@vger.kernel.org,
Axel Rasmussen <axelrasmussen@google.com>,
James Houghton <jthoughton@google.com>,
Hugh Dickins <hughd@google.com>, Yang Shi <shy828301@gmail.com>,
Miaohe Lin <linmiaohe@huawei.com>,
David Hildenbrand <david@redhat.com>,
David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Peter Xu <peterx@redhat.com>,
Rongwei Wang <rongwei.wang@linux.alibaba.com>,
SeongJae Park <sj@kernel.org>, Song Liu <songliubraving@fb.com>,
Vlastimil Babka <vbabka@suse.cz>,
Chris Kennelly <ckennelly@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Minchan Kim <minchan@kernel.org>,
Patrick Xia <patrickx@google.com>,
Zach O'Keefe <zokeefe@google.com>
Subject: Re: [PATCH mm-unstable 3/9] mm/madvise: add file and shmem support to MADV_COLLAPSE
Date: Mon, 15 Aug 2022 10:23:36 +0800 [thread overview]
Message-ID: <202208151032.dIQzLJma-lkp@intel.com> (raw)
In-Reply-To: <20220812012843.3948330-4-zokeefe@google.com>
Hi Zach,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: hexagon-randconfig-r045-20220812 (https://download.01.org/0day-ci/archive/20220815/202208151032.dIQzLJma-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/dff08746d6f7b9387b94360b66bd9db644542991
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122
git checkout dff08746d6f7b9387b94360b66bd9db644542991
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/fork.c:86:
>> include/linux/khugepaged.h:53:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
}
^
kernel/fork.c:163:13: warning: no previous prototype for function 'arch_release_task_struct' [-Wmissing-prototypes]
void __weak arch_release_task_struct(struct task_struct *tsk)
^
kernel/fork.c:163:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __weak arch_release_task_struct(struct task_struct *tsk)
^
static
kernel/fork.c:852:20: warning: no previous prototype for function 'arch_task_cache_init' [-Wmissing-prototypes]
void __init __weak arch_task_cache_init(void) { }
^
kernel/fork.c:852:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void __init __weak arch_task_cache_init(void) { }
^
static
kernel/fork.c:947:12: warning: no previous prototype for function 'arch_dup_task_struct' [-Wmissing-prototypes]
int __weak arch_dup_task_struct(struct task_struct *dst,
^
kernel/fork.c:947:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int __weak arch_dup_task_struct(struct task_struct *dst,
^
static
3 warnings and 1 error generated.
--
In file included from mm/mmap.c:40:
>> include/linux/khugepaged.h:53:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
}
^
1 error generated.
vim +53 include/linux/khugepaged.h
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 33
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 34 static inline void khugepaged_exit(struct mm_struct *mm)
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 35 {
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 36 if (test_bit(MMF_VM_HUGEPAGE, &mm->flags))
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 37 __khugepaged_exit(mm);
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 38 }
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 39 #else /* CONFIG_TRANSPARENT_HUGEPAGE */
d2081b2bf8195b Yang Shi 2022-05-19 40 static inline void khugepaged_fork(struct mm_struct *mm, struct mm_struct *oldmm)
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 41 {
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 42 }
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 43 static inline void khugepaged_exit(struct mm_struct *mm)
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 44 {
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 45 }
c791576c60288c Yang Shi 2022-05-19 46 static inline void khugepaged_enter_vma(struct vm_area_struct *vma,
6d50e60cd2edb5 David Rientjes 2014-10-29 47 unsigned long vm_flags)
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 48 {
ba76149f47d8c9 Andrea Arcangeli 2011-01-13 49 }
dff08746d6f7b9 Zach O'Keefe 2022-08-11 50 static inline int collapse_pte_mapped_thp(struct mm_struct *mm,
dff08746d6f7b9 Zach O'Keefe 2022-08-11 51 unsigned long addr, bool install_pmd)
27e1f8273113ad Song Liu 2019-09-23 52 {
27e1f8273113ad Song Liu 2019-09-23 @53 }
4aab2be0983031 Vijay Balakrishna 2020-10-10 54
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-08-15 2:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 1:28 [PATCH mm-unstable 0/9] mm: add file/shmem support to MADV_COLLAPSE Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 1/9] mm/shmem: add flag to enforce shmem THP in hugepage_vma_check() Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 2/9] mm/khugepaged: attempt to map file/shmem-backed pte-mapped THPs by pmds Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 3/9] mm/madvise: add file and shmem support to MADV_COLLAPSE Zach O'Keefe
2022-08-15 2:23 ` kernel test robot [this message]
2022-08-15 5:41 ` kernel test robot
2022-08-15 17:09 ` Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 4/9] mm/khugepaged: add tracepoint to hpage_collapse_scan_file() Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 5/9] selftests/vm: dedup THP helpers Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 6/9] selftests/vm: modularize thp collapse memory operations Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 7/9] selftests/vm: add thp collapse file and tmpfs testing Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 8/9] selftests/vm: add thp collapse shmem testing Zach O'Keefe
2022-08-12 1:28 ` [PATCH mm-unstable 9/9] selftests/vm: add selftest for MADV_COLLAPSE of uffd-minor memory Zach O'Keefe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208151032.dIQzLJma-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=ckennelly@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jthoughton@google.com \
--cc=kbuild-all@lists.01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linmiaohe@huawei.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=minchan@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=patrickx@google.com \
--cc=peterx@redhat.com \
--cc=rientjes@google.com \
--cc=rongwei.wang@linux.alibaba.com \
--cc=shy828301@gmail.com \
--cc=sj@kernel.org \
--cc=songliubraving@fb.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).