From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBB3C00140 for ; Mon, 15 Aug 2022 05:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbiHOFlh (ORCPT ); Mon, 15 Aug 2022 01:41:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbiHOFlg (ORCPT ); Mon, 15 Aug 2022 01:41:36 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73E7C14081 for ; Sun, 14 Aug 2022 22:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660542094; x=1692078094; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=B2uWyyHRSzgByKXaC+wjLJswLcAS9PxLK4BBhJ8umn8=; b=nYE/n8d18yrxyL/1a3rUxRalfmEHv8tCN+dzJQcSrqj8EF0Ss2i3F7aD ANnLGBv5gm+05Gl1TZeDthavv6rWl7duxY85pi6xYM0FWiVh2hl7wJNRT F6FWueHT4ee7nJWSaocs7sZRSxO6HHOpflosKo1SnKdCjr0Axtj5viIko ol8F1meBZ6iYthsJ6+zQGUmcdmfvRin0f1Z0vAOUsIfMT5V7GXfTxf4la ZZfRFeWAr8qMBxuP3RFDEE76vIGW+sJTVlLCQZWA5gU0a7b5xUa03eUUk WzlpnewE+n8T8rIUpf3cuAcSaej4UD4/DR4JpAV+VSl6pW8zrBkhFs42I w==; X-IronPort-AV: E=McAfee;i="6400,9594,10439"; a="378183309" X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="378183309" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2022 22:41:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,237,1654585200"; d="scan'208";a="639536842" Received: from lkp-server02.sh.intel.com (HELO 3d2a4d02a2a9) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 14 Aug 2022 22:41:28 -0700 Received: from kbuild by 3d2a4d02a2a9 with local (Exim 4.96) (envelope-from ) id 1oNSqu-0000oz-0t; Mon, 15 Aug 2022 05:41:28 +0000 Date: Mon, 15 Aug 2022 13:41:02 +0800 From: kernel test robot To: Zach O'Keefe , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List , linux-api@vger.kernel.org, Axel Rasmussen , James Houghton , Hugh Dickins , Yang Shi , Miaohe Lin , David Hildenbrand , David Rientjes , Matthew Wilcox , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Chris Kennelly , "Kirill A. Shutemov" , Minchan Kim , Patrick Xia , Zach O'Keefe Subject: Re: [PATCH mm-unstable 3/9] mm/madvise: add file and shmem support to MADV_COLLAPSE Message-ID: <202208151331.uxreCJWj-lkp@intel.com> References: <20220812012843.3948330-4-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220812012843.3948330-4-zokeefe@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org Hi Zach, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220815/202208151331.uxreCJWj-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/dff08746d6f7b9387b94360b66bd9db644542991 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-add-file-shmem-support-to-MADV_COLLAPSE/20220812-093122 git checkout dff08746d6f7b9387b94360b66bd9db644542991 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/khugepaged.c: In function 'set_huge_pmd': >> mm/khugepaged.c:1403:13: error: assignment of read-only variable 'vmf' 1403 | vmf = (struct vm_fault) { | ^ vim +/vmf +1403 mm/khugepaged.c 1393 1394 /* hpage must be locked, and mmap_lock must be held in write */ 1395 static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, 1396 pmd_t *pmdp, struct page *hpage) 1397 { 1398 struct vm_fault vmf; 1399 1400 VM_BUG_ON(!PageTransHuge(hpage)); 1401 mmap_assert_write_locked(vma->vm_mm); 1402 > 1403 vmf = (struct vm_fault) { 1404 .vma = vma, 1405 .address = addr, 1406 .flags = 0, 1407 .pmd = pmdp, 1408 }; 1409 1410 if (do_set_pmd(&vmf, hpage)) 1411 return SCAN_FAIL; 1412 1413 get_page(hpage); 1414 return SCAN_SUCCEED; 1415 } 1416 -- 0-DAY CI Kernel Test Service https://01.org/lkp