From: Ravi Jonnalagadda <ravis.opensrc@micron.com>
To: <linux-mm@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-arch@vger.kernel.org>,
<linux-api@vger.kernel.org>, <luto@kernel.org>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dietmar.eggemann@arm.com>, <vincent.guittot@linaro.org>,
<dave.hansen@linux.intel.com>, <hpa@zytor.com>, <arnd@arndb.de>,
<akpm@linux-foundation.org>, <x86@kernel.org>,
<aneesh.kumar@linux.ibm.com>, <gregory.price@memverge.com>,
<ying.huang@intel.com>, <jgroves@micron.com>,
<ravis.opensrc@micron.com>, <sthanneeru@micron.com>,
<emirakhur@micron.com>, <vtanna@micron.com>
Subject: [PATCH 1/2] memory tier: Introduce sysfs for tier interleave weights.
Date: Wed, 27 Sep 2023 15:20:01 +0530 [thread overview]
Message-ID: <20230927095002.10245-2-ravis.opensrc@micron.com> (raw)
In-Reply-To: <20230927095002.10245-1-ravis.opensrc@micron.com>
From: Srinivasulu Thanneeru <sthanneeru@micron.com>
Allocating pages across tiers is accomplished by provisioning
interleave weights for each tier, with the distribution based on
these weight values.
By default, all tiers will have a weight of 1, which means
default standard page allocation. By default all nodes within
tier will have weight of 1.
Signed-off-by: Srinivasulu Thanneeru <sthanneeru@micron.com>
Co-authored-by: Ravi Jonnalagadda <ravis.opensrc@micron.com>
---
include/linux/memory-tiers.h | 2 ++
mm/memory-tiers.c | 46 +++++++++++++++++++++++++++++++++++-
2 files changed, 47 insertions(+), 1 deletion(-)
diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h
index 437441cdf78f..c62d286749d0 100644
--- a/include/linux/memory-tiers.h
+++ b/include/linux/memory-tiers.h
@@ -19,6 +19,8 @@
*/
#define MEMTIER_ADISTANCE_DRAM ((4 * MEMTIER_CHUNK_SIZE) + (MEMTIER_CHUNK_SIZE >> 1))
+#define MAX_TIER_INTERLEAVE_WEIGHT 100
+
struct memory_tier;
struct memory_dev_type {
/* list of memory types that are part of same tier as this type */
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index 37a4f59d9585..7e06c9e0fa41 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -13,6 +13,11 @@ struct memory_tier {
struct list_head list;
/* list of all memory types part of this tier */
struct list_head memory_types;
+ /*
+ * By default all tiers will have weight as 1, which means they
+ * follow default standard allocation.
+ */
+ unsigned short interleave_weight;
/*
* start value of abstract distance. memory tier maps
* an abstract distance range,
@@ -145,8 +150,45 @@ static ssize_t nodelist_show(struct device *dev,
}
static DEVICE_ATTR_RO(nodelist);
+static ssize_t interleave_weight_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ int ret;
+ struct memory_tier *tier = to_memory_tier(dev);
+
+ mutex_lock(&memory_tier_lock);
+ ret = sysfs_emit(buf, "%u\n", tier->interleave_weight);
+ mutex_unlock(&memory_tier_lock);
+
+ return ret;
+}
+
+static ssize_t interleave_weight_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t size)
+{
+ unsigned short value;
+ int ret;
+ struct memory_tier *tier = to_memory_tier(dev);
+
+ ret = kstrtou16(buf, 0, &value);
+
+ if (ret)
+ return ret;
+ if (value > MAX_TIER_INTERLEAVE_WEIGHT)
+ return -EINVAL;
+
+ mutex_lock(&memory_tier_lock);
+ tier->interleave_weight = value;
+ mutex_unlock(&memory_tier_lock);
+
+ return size;
+}
+static DEVICE_ATTR_RW(interleave_weight);
+
static struct attribute *memtier_dev_attrs[] = {
&dev_attr_nodelist.attr,
+ &dev_attr_interleave_weight.attr,
NULL
};
@@ -489,8 +531,10 @@ static struct memory_tier *set_node_memory_tier(int node)
memtype = node_memory_types[node].memtype;
node_set(node, memtype->nodes);
memtier = find_create_memory_tier(memtype);
- if (!IS_ERR(memtier))
+ if (!IS_ERR(memtier)) {
rcu_assign_pointer(pgdat->memtier, memtier);
+ memtier->interleave_weight = 1;
+ }
return memtier;
}
--
2.39.3
next prev parent reply other threads:[~2023-09-27 9:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 9:50 [RFC PATCH 0/2] mm: mempolicy: Multi-tier interleaving Ravi Jonnalagadda
2023-09-27 9:50 ` Ravi Jonnalagadda [this message]
2023-10-02 10:26 ` [PATCH 1/2] memory tier: Introduce sysfs for tier interleave weights Jonathan Cameron
2023-09-27 9:50 ` [PATCH 2/2] mm: mempolicy: Interleave policy for tiered memory nodes Ravi Jonnalagadda
2023-09-28 6:56 ` Huang, Ying
2023-09-28 18:25 ` Gregory Price
2023-10-02 10:48 ` Jonathan Cameron
2023-10-20 17:05 ` kernel test robot
2023-09-28 6:14 ` [RFC PATCH 0/2] mm: mempolicy: Multi-tier interleaving Huang, Ying
2023-10-03 5:07 ` [EXT] " Srinivasulu Thanneeru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927095002.10245-2-ravis.opensrc@micron.com \
--to=ravis.opensrc@micron.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=emirakhur@micron.com \
--cc=gregory.price@memverge.com \
--cc=hpa@zytor.com \
--cc=jgroves@micron.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=sthanneeru@micron.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vtanna@micron.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).