From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-190c.mail.infomaniak.ch (smtp-190c.mail.infomaniak.ch [185.125.25.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CA96280F for ; Tue, 23 Jan 2024 15:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.25.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706024422; cv=none; b=pREo69E8IxHj3rlxhpm9Nxg+SqpR5uLkTqhCFRGnKlObjHaPSHz2/N1sW4LFCFwYz3j2FCsvO6x68zJi/V2irI5TnU3qUykMHcOHgVitPBSnYMvlw0jRG0Ttp+nsEFnO9C1tsvuDveqpV4jgtSfXArEysvBjsNvN4xiXP1QsshY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706024422; c=relaxed/simple; bh=zgqI9UR8YogjZoN9u8vWb4dHmJvB8ik8X67zHyKWp0E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a6TDUeJ+3rImn6OQ6XI1/uNeMRCeLLvb9P3v6UmqZti1Vrk9Hp6NQkpYWS0zMWefLPYhy2S8QCOW/H38e+MWcsBFWVJMSHDs7+ykap0k6Ri4QPt/lL4O0UPuO57skHHIuu/7Oe/Hdpr8JqpiX41ykiLZuixQcTRriEMH7HCOYKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=XXbo1DEE; arc=none smtp.client-ip=185.125.25.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="XXbo1DEE" Received: from smtp-3-0000.mail.infomaniak.ch (unknown [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TKB1N6n0DzMq5jw; Tue, 23 Jan 2024 16:32:56 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4TKB1M6BnkzrB; Tue, 23 Jan 2024 16:32:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1706023976; bh=zgqI9UR8YogjZoN9u8vWb4dHmJvB8ik8X67zHyKWp0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XXbo1DEEM3NL5OR6r67arzFI93BlDNA3jzA0bdkXrlPcz9PWoynqbZ9DRchI+s6Hg sumZzKWpg5rsuUXtHAg+MW1vTX8Wek22Z+dFFd/K6v6792zx7BcdklDSFmE1Z7xIYb udJuqxRWB40sTpRe3IUczKgQk87Ey5o7YLkGSRLM= Date: Tue, 23 Jan 2024 16:32:52 +0100 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Huyadi Cc: "jmorris@namei.org" , "serge@hallyn.com" , "shuah@kernel.org" , "mathieu.desnoyers@efficios.com" , "amir73il@gmail.com" , "brauner@kernel.org" , "avagin@google.com" , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "514118380@qq.com" <514118380@qq.com>, "konstantin.meskhidze@huawei.com" Subject: Re: =?utf-8?B?5Zue5aSN?= =?utf-8?Q?=3A?= [PATCH v4] selftests/landlock:Fix two build issues Message-ID: <20240123.deeT9hegh4vo@digikod.net> References: <20240115102409.19799-1-hu.yadi@h3c.com> <20240119.Ugaehae2ze5b@digikod.net> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Infomaniak-Routing: alpha On Tue, Jan 23, 2024 at 12:04:17PM +0000, Huyadi wrote: > > >> Changes v3 -> v2: > >> - add helper of gettid instead of __NR_gettid > >> - add gcc/glibc version info in comments Changes v1 -> v2: > >> - fix whitespace error > >> - replace SYS_gettid with _NR_gettid > >> > >> tools/testing/selftests/landlock/fs_test.c | 5 ++++- > >> tools/testing/selftests/landlock/net_test.c | 7 ++++++- > >> 2 files changed, 10 insertions(+), 2 deletions(-) > >> > >> diff --git a/tools/testing/selftests/landlock/fs_test.c > >> b/tools/testing/selftests/landlock/fs_test.c > >> index 18e1f86a6234..a992cf7c0ad1 100644 > >> --- a/tools/testing/selftests/landlock/fs_test.c > >> +++ b/tools/testing/selftests/landlock/fs_test.c > >> @@ -4572,7 +4572,10 @@ FIXTURE_VARIANT(layout3_fs) > >> /* clang-format off */ > >> FIXTURE_VARIANT_ADD(layout3_fs, tmpfs) { > >> /* clang-format on */ > >> - .mnt = mnt_tmp, > >> + .mnt = { > >> + .type = "tmpfs", > >> + .data = "size=4m,mode=700", > >> + }, > > > >I requested some changes here. > > > > Could you give me some inspiration how to fix it? > it looks fine to me to assign value as above, which consistent with other pseudo FS tests. > Thanks in advance. Just add and use this for the two tmpfs data: #define MNT_TMP_DATA "size=4m,mode=700" You can also make the mnt_tmp variable static const. > > >> .file_path = file1_s1d1, > >> }; > >> >