From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2474B84A45 for ; Fri, 9 Feb 2024 19:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707508525; cv=none; b=c3LKGKIZYsN9MpnFmUji8Lqkt16k7+8H8QL/8/xAaO4J2gcWFSDj+5Ciztvg58xL9ISiAhaXi67t9gFkAnXcSV+45t9ic1khzyL3fPo9/qpR6YKwrfuoMC4hD6vrsegTDQx1RHeXdSjpAVRTJ97fI3Tgko0kLKREBnYLge8rtxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707508525; c=relaxed/simple; bh=ct4pYLqbWEvaFepWlnW0LcNyrdRiTi4jZVyKCOleQ9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vCHX2MHYeArDRQXLVDeKTbBZesfC60//tSPIQTZTj6iXKHA5Zrq6hBiBvHwqV2ARehXoTAl6wksDEY6cyaL9Y/Pasf8R7Zr5SeWMQb00myr5YVzJsxajHx8ESPe8BSJiw87GD/gGo5XERP+IKPLUhBXU9bXy3/UIZP92oA1YUwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AwTi6Ub3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AwTi6Ub3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707508522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7Em5WxJdAGOzFKe0pJRNSvAunQeanzmTyzeJclMZdng=; b=AwTi6Ub35CQk5GFtv61AJH8GODbhI3U6CrAhPhrMUnLKHzP0dDK/3wgNyZkwYjM/P8PDZx J+TIAIY2co5tmZ1N/dqa4AGaBITRX5rk0Y9PuiAQkt1vNwkX1E7E9NoCO/vXc7JZcZPxhc jcnX1n+qCdiV3eKqLMmOfPOkYVpy98E= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-OsTCtYDJO_q9nZf8IYR7-w-1; Fri, 09 Feb 2024 14:55:16 -0500 X-MC-Unique: OsTCtYDJO_q9nZf8IYR7-w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 37EF738130AE; Fri, 9 Feb 2024 19:55:16 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.63]) by smtp.corp.redhat.com (Postfix) with SMTP id 90968492BE2; Fri, 9 Feb 2024 19:55:14 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 9 Feb 2024 20:54:00 +0100 (CET) Date: Fri, 9 Feb 2024 20:53:58 +0100 From: Oleg Nesterov To: Christian Brauner Cc: "Eric W. Biederman" , Andy Lutomirski , Tycho Andersen , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] signal: add the "int si_code" arg to prepare_kill_siginfo() Message-ID: <20240209195332.GA24647@redhat.com> References: <20240209130620.GA8039@redhat.com> <87sf21zjy8.fsf@email.froward.int.ebiederm.org> <20240209163914.GE3282@redhat.com> <20240209-traben-geothermie-8c6aa7e1984f@brauner> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240209-traben-geothermie-8c6aa7e1984f@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 On 02/09, Christian Brauner wrote: > > On Fri, Feb 09, 2024 at 05:39:14PM +0100, Oleg Nesterov wrote: > > On 02/09, Eric W. Biederman wrote: > > > > > > Could you can pass in the destination type instead of the si_code? > > > Something like I have shown below? > > > > ... > > > > > info->si_code = (type == PIDTYPE_PID) ? SI_TKILL : SI_USER; > > > > Yes, I considered this option too. > > > > OK, will send V3 tomorrow. > > Hm, I don't think that's necessary if you're happy to have me just fix > that up in tree. Thank you!!! looks obviously correct, but again, I will double check tomorrow just in case. > but I have a baby on my lap so double check, please: ;) I'm familiar with this. Oleg.