* [PATCH] uapi: linux/kd.h: include missing header
@ 2024-05-23 9:23 Dmitry V. Levin
2024-05-23 9:29 ` Alexey Gladkov
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry V. Levin @ 2024-05-23 9:23 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Alexey Gladkov, Jiri Slaby, linux-api, linux-kernel
Given that linux/kd.h now uses macros defined in linux/ioctl.h,
do not rely on that header being already included by linux/kd.h users
and include linux/ioctl.h explicitly.
This bug was found by strace CI.
Fixes: 8c467f330059 ("VT: Use macros to define ioctls")
Signed-off-by: Dmitry V. Levin <ldv@strace.io>
---
include/uapi/linux/kd.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
index 8ddb2219a84b..8fcce939ba25 100644
--- a/include/uapi/linux/kd.h
+++ b/include/uapi/linux/kd.h
@@ -3,6 +3,7 @@
#define _UAPI_LINUX_KD_H
#include <linux/types.h>
#include <linux/compiler.h>
+#include <linux/ioctl.h>
/* 0x4B is 'K', to avoid collision with termios and vt */
#define KD_IOCTL_BASE 'K'
--
ldv
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] uapi: linux/kd.h: include missing header
2024-05-23 9:23 [PATCH] uapi: linux/kd.h: include missing header Dmitry V. Levin
@ 2024-05-23 9:29 ` Alexey Gladkov
0 siblings, 0 replies; 2+ messages in thread
From: Alexey Gladkov @ 2024-05-23 9:29 UTC (permalink / raw)
To: Dmitry V. Levin; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-api, linux-kernel
On Thu, May 23, 2024 at 12:23:10PM +0300, Dmitry V. Levin wrote:
> Given that linux/kd.h now uses macros defined in linux/ioctl.h,
> do not rely on that header being already included by linux/kd.h users
> and include linux/ioctl.h explicitly.
>
> This bug was found by strace CI.
>
> Fixes: 8c467f330059 ("VT: Use macros to define ioctls")
> Signed-off-by: Dmitry V. Levin <ldv@strace.io>
Acked-by: Alexey Gladkov <legion@kernel.org>
> ---
> include/uapi/linux/kd.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/kd.h b/include/uapi/linux/kd.h
> index 8ddb2219a84b..8fcce939ba25 100644
> --- a/include/uapi/linux/kd.h
> +++ b/include/uapi/linux/kd.h
> @@ -3,6 +3,7 @@
> #define _UAPI_LINUX_KD_H
> #include <linux/types.h>
> #include <linux/compiler.h>
> +#include <linux/ioctl.h>
>
> /* 0x4B is 'K', to avoid collision with termios and vt */
> #define KD_IOCTL_BASE 'K'
> --
> ldv
>
--
Rgrds, legion
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-23 9:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 9:23 [PATCH] uapi: linux/kd.h: include missing header Dmitry V. Levin
2024-05-23 9:29 ` Alexey Gladkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).