From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Aleksa Sarai <cyphar@cyphar.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>, Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle_at(2)
Date: Mon, 27 May 2024 14:22:26 +0200 [thread overview]
Message-ID: <20240527-montag-beruhen-523b74214339@brauner> (raw)
In-Reply-To: <ZlMADupKkN0ITgG5@infradead.org>
On Sun, May 26, 2024 at 02:25:34AM -0700, Christoph Hellwig wrote:
> On Thu, May 23, 2024 at 01:57:32PM -0700, Aleksa Sarai wrote:
> > Now that we provide a unique 64-bit mount ID interface in statx, we can
> > now provide a race-free way for name_to_handle_at(2) to provide a file
> > handle and corresponding mount without needing to worry about racing
> > with /proc/mountinfo parsing.
>
> file handles are not tied to mounts, they are tied to super_blocks,
> and they can survive reboots or (less relevant) remounts. This thus
> seems like a very confusing if not wrong interfaces.
I'm not fond of the interface as I've said on an earlier version, but
name_to_handle_at() has always exposed the mount id. IOW, this isn't
adding a new concept to the system call.
prev parent reply other threads:[~2024-05-27 12:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 20:57 [PATCH RFC v2] fhandle: expose u64 mount id to name_to_handle_at(2) Aleksa Sarai
2024-05-24 4:58 ` Amir Goldstein
2024-05-26 9:25 ` Christoph Hellwig
2024-05-26 19:01 ` Aleksa Sarai
2024-05-27 11:47 ` Christoph Hellwig
2024-05-27 12:29 ` Christian Brauner
2024-05-27 13:17 ` Christian Brauner
2024-05-27 15:47 ` Trond Myklebust
2024-05-28 7:05 ` Christian Brauner
2024-05-27 16:18 ` Christoph Hellwig
2024-05-27 13:34 ` Jan Kara
2024-05-27 16:24 ` Christoph Hellwig
2024-05-28 8:20 ` Christian Brauner
2024-05-28 8:28 ` Christoph Hellwig
2024-05-28 9:17 ` Christian Brauner
2024-05-28 10:55 ` Christoph Hellwig
2024-05-28 12:04 ` Christian Brauner
2024-05-28 13:22 ` Christoph Hellwig
2024-05-28 13:28 ` Miklos Szeredi
2024-05-29 6:34 ` Christoph Hellwig
2024-06-01 8:12 ` Aleksa Sarai
2024-06-03 10:30 ` Jan Kara
2024-06-04 5:22 ` Christoph Hellwig
2024-05-29 7:40 ` Christian Brauner
2024-05-31 8:14 ` Christoph Hellwig
2024-05-31 10:28 ` Christian Brauner
2024-05-26 22:32 ` Trond Myklebust
2024-05-27 11:49 ` hch
2024-05-27 15:38 ` Trond Myklebust
2024-05-27 16:29 ` hch
2024-05-28 7:12 ` Christian Brauner
2024-05-28 7:15 ` hch
2024-05-28 10:11 ` Jan Kara
2024-05-28 10:56 ` hch
2024-05-28 23:25 ` Dave Chinner
2024-05-29 6:24 ` hch
2024-05-29 7:23 ` Amir Goldstein
2024-05-27 12:22 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240527-montag-beruhen-523b74214339@brauner \
--to=brauner@kernel.org \
--cc=alex.aring@gmail.com \
--cc=amir73il@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=cyphar@cyphar.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox