From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A68937A141; Wed, 24 Jul 2024 07:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.107.17.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721807739; cv=none; b=K7eUBlH7DDeHiO9Ctj9OYprnEfLgG6K1FVptZ+kbNdPspZLAQFsVW33YQgpR0QILJeO+zYmjsePUeyaEYA9nnfcEiS2S/iSRWdvP57qP+8LShtByUq0r12hJToOH5NMluY/u6gXs+Tvq0GELQ77wNo/h0Odg2VT8NpbPUsN3gvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721807739; c=relaxed/simple; bh=EPj+8jND55oLT0Yv4yVYXVWeyqe6ixwiN3eJg1f/bx8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cA1LkC8uqYUFrhq34cRdiI1sPI745jhJqJGYvvWnOX3tjhpRdcNkdFeSIV9D5HfuMvn1j60NtH/xspNhHF+nXsgCjFp9uxBzI6GWllbM2zhQzrefNuxtpLUIgbap8UMzU2I3nePrCI0JQYshXaK/N/Uy0NiRoMDj4d+PjH1pn88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strace.io; spf=pass smtp.mailfrom=altlinux.org; arc=none smtp.client-ip=194.107.17.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strace.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 2092B72C8FB; Wed, 24 Jul 2024 10:46:30 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 141F37CCB3C; Wed, 24 Jul 2024 10:46:30 +0300 (IDT) Date: Wed, 24 Jul 2024 10:46:30 +0300 From: "Dmitry V. Levin" To: Jiri Olsa Cc: Steven Rostedt , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Andrii Nakryiko , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, bpf@vger.kernel.org, Thomas Gleixner , "Borislav Petkov (AMD)" , Ingo Molnar , Andy Lutomirski , Deepak Gupta , Stephen Rothwell Subject: Re: [PATCH 1/2] uprobe: Change uretprobe syscall scope and number Message-ID: <20240724074629.GA11265@altlinux.org> References: <20240712135228.1619332-1-jolsa@kernel.org> <20240712135228.1619332-2-jolsa@kernel.org> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712135228.1619332-2-jolsa@kernel.org> On Fri, Jul 12, 2024 at 03:52:27PM +0200, Jiri Olsa wrote: > After discussing with Arnd [1] it's preferable to change uretprobe > syscall number to 467 to omit the merge conflict with xattrat syscalls. > > Also changing the ABI to 'common' which will ease up the global > scripts/syscall.tbl management. One consequence is we generate uretprobe > syscall numbers for ABIs that do not support uretprobe syscall, but the > syscall still returns -ENOSYS when called in that ABI. > > [1] https://lore.kernel.org/lkml/784a34e5-4654-44c9-9c07-f9f4ffd952a0@app.fastmail.com/ > > Fixes: 190fec72df4a ("uprobe: Wire up uretprobe system call") > Suggested-by: Arnd Bergmann > Signed-off-by: Jiri Olsa > --- > arch/x86/entry/syscalls/syscall_64.tbl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl > index 6452c2ec469a..dabf1982de6d 100644 > --- a/arch/x86/entry/syscalls/syscall_64.tbl > +++ b/arch/x86/entry/syscalls/syscall_64.tbl > @@ -384,7 +384,7 @@ > 460 common lsm_set_self_attr sys_lsm_set_self_attr > 461 common lsm_list_modules sys_lsm_list_modules > 462 common mseal sys_mseal > -463 64 uretprobe sys_uretprobe > +467 common uretprobe sys_uretprobe > > # > # Due to a historical design error, certain syscalls are numbered differently Isn't include/uapi/asm-generic/unistd.h expected to be updated as well? As of mainline commit v6.10-12246-g786c8248dbd3, it still contains #define __NR_uretprobe 463 -- ldv