From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Miao Wang <shankerwangmiao@gmail.com>
Cc: Xi Ruoyao <xry111@xry111.site>,
Huacai Chen <chenhuacai@kernel.org>,
loongarch@lists.linux.dev, Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, WANG Xuerui <kernel@xen0n.name>,
linux-api@vger.kernel.org
Subject: Re: It is correct to introduce new sys calls to stable versions?
Date: Tue, 20 Aug 2024 21:36:13 +0800 [thread overview]
Message-ID: <2024082057-coherence-lethargy-3513@gregkh> (raw)
In-Reply-To: <DF762B6F-360A-4C0C-8C85-55686417209B@gmail.com>
On Tue, Aug 20, 2024 at 09:19:04PM +0800, Miao Wang wrote:
> Hi, Greg
>
> I saw you have included commit 7697a0fe0154 ("LoongArch: Define
> __ARCH_WANT_NEW_STAT in unistd.h") in your stable trees, which
> actually introduced new sys calls newfstatat and fstat to Loongarch.
See the documentation in that commit for why it was done.
> I wonder if it is correct to add new syscalls, which actually changes
> the kernel features, in stable releases, as it might confuse downstream
> developers because they may assume the existence of a certain feature
> after a certain version.
Version numbers should never be used to be checked for anything as they
are only a "moment in time" stamp. They do not reflect features or
capabilities or anything else.
Test for functionality if you want to check for something, that's the
only way it will ever work on all of the variants of different
"enterprise" kernels.
thanks,
greg k-h
next prev parent reply other threads:[~2024-08-20 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 13:19 It is correct to introduce new sys calls to stable versions? Miao Wang
2024-08-20 13:29 ` Cyril Hrubis
2024-08-20 13:36 ` Greg Kroah-Hartman [this message]
2024-08-20 13:49 ` Miao Wang
2024-08-20 14:00 ` Greg Kroah-Hartman
2024-08-20 15:05 ` Willy Tarreau
2024-08-20 16:09 ` Miao Wang
2024-08-20 18:30 ` Willy Tarreau
2024-08-20 19:24 ` Miao Wang
2024-08-20 14:44 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024082057-coherence-lethargy-3513@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-api@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=shankerwangmiao@gmail.com \
--cc=stable@vger.kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).