From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D7A31ADC98 for ; Tue, 14 Jan 2025 11:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736852554; cv=none; b=GfgesbR8I57sJqEfz6yZ6dZpnFbzD7RuDaglzOgIilpPOyy2QwOd+O/1LhoWB0j69RalsCXxP1FKNJxtGp6hXQq50Qa2A0+l/u896VNxyKSLvysQ+4h6vGiBiWkGcKj1rYWmtoTCy27F0RGKupk0y2wtQhcBhGEy/glk0uDhWF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736852554; c=relaxed/simple; bh=Ovo/VNfzR+CoK/PJl5X0EEHPgpzOZZFY8SPWGupSzYw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=szcdw6FInfrWWxIA1YHgau35SViEVXpY8gc+3Jpk6dTJUnrePjbF+baTpMSOfca14lI6TsJuF+Ovlp2J+eDprZRzELY3MWsg6D/RPNbE9NlEsz7vsjI7KVADj/vrwkqv7r/lOpUsCeWoHuGUhfd7SAJ3BMitg3TKKSVkS8pCWRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JgfaoeCr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JgfaoeCr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736852551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ovo/VNfzR+CoK/PJl5X0EEHPgpzOZZFY8SPWGupSzYw=; b=JgfaoeCr8NlCaGTlcP9MdmbnDj6GjnHDRv+DQS9fYmt1e3huFtck/DW0fPqm5C7FqT7QbR sCzUttNmj01aI57OarVCgPtRy2wk2p2nJBKpRYKAJQIFQfYprpv/gdSbqZahvZD1ewp2Xx 00wiV0ohI2rZuAAAo8u1PmcNX5b/mPw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-D0WvGm4gNfqO2dO07wT6UQ-1; Tue, 14 Jan 2025 06:02:27 -0500 X-MC-Unique: D0WvGm4gNfqO2dO07wT6UQ-1 X-Mimecast-MFC-AGG-ID: D0WvGm4gNfqO2dO07wT6UQ Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49A4219560A2; Tue, 14 Jan 2025 11:02:24 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.88]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 6FF3519560A3; Tue, 14 Jan 2025 11:02:15 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 14 Jan 2025 12:01:59 +0100 (CET) Date: Tue, 14 Jan 2025 12:01:50 +0100 From: Oleg Nesterov To: Peter Zijlstra Cc: Jiri Olsa , Aleksa Sarai , Eyal Birger , mhiramat@kernel.org, linux-kernel , linux-trace-kernel@vger.kernel.org, BPF-dev-list , Song Liu , Yonghong Song , John Fastabend , tglx@linutronix.de, bp@alien8.de, x86@kernel.org, linux-api@vger.kernel.org, Andrii Nakryiko , Daniel Borkmann , Alexei Starovoitov , Andrii Nakryiko , "rostedt@goodmis.org" , rafi@rbk.io, Shmulik Ladkani Subject: Re: Crash when attaching uretprobes to processes running in Docker Message-ID: <20250114110149.GB19816@redhat.com> References: <20250110.152323-sassy.torch.lavish.rent-vKX3ul5B3qyi@cyphar.com> <20250114104215.GD8362@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250114104215.GD8362@noisy.programming.kicks-ass.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 01/14, Peter Zijlstra wrote: > > On Tue, Jan 14, 2025 at 10:22:20AM +0100, Jiri Olsa wrote: > > > > hack below seems to fix the issue, it's using rbx to signal that uretprobe > > syscall got executed, if not, trampoline does int3 and executes uretprobe > > handler in the old way > > > > unfortunately now the uretprobe trampoline size crosses the xol slot limit so > > will need to come up with some generic/arch code solution for that, code below > > is neglecting that for now > > Can't you detect the filter earlier and simply not install the > trampoline? Did you mean detect the filter in prepare_uretprobe() ? The probed function can install the filter before return... Oleg.