From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 365142135BE for ; Tue, 14 Jan 2025 22:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736892683; cv=none; b=BeqlMdoTAcJr+2o7lMi3Pj/VRBtjEVcQ2fI7HeDKwYrD8OP6Q8Bpu+AH/SARBQUcM1kRsQzBaOb//PtGFKAqWEMSt4XR9jIg4xN2ZQclCsVOYD/wFQHp4tqGPUvcnHWULZni7pHySd31m8pegbZxAyyDHHPynsZSfxm8750fzrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736892683; c=relaxed/simple; bh=+ovgz39tY88dwtzotQQdo6p6n/6QPXchjNTUZS4C/5I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QqzrinE4V70s2Nn0wFCL4gu5A869wNgc366RXZOLD+qSpZX9N2cN3sTgoBPOq578GT2rW6s43u23PumZFtl5h37lXf0Z6UPIu9lLdkXBcDStkGjCwPNR6dcqIu3C4T3LznMCQnJRGXc/29SztmtNA/2iuNwmeFXze65HxiY09YE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HccjjdC0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HccjjdC0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736892681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ovgz39tY88dwtzotQQdo6p6n/6QPXchjNTUZS4C/5I=; b=HccjjdC0H2huo2I26pVaUastT8WWy8c1sLTUxJ0WbrKUXWq+ZjvX2/o0+r2IYFSjOr4gQF Cbr9iLBBIt2qXnUPpoqnMJdnpFCe9LdfpxFwCnGuue5/mt1UtaH66jBffEaVFS5Eh8/Cl+ lvF41orVKQtYBHrvwBZaY0ElvsRRa8s= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-fNVoz8YDMMiv09T73PKnTQ-1; Tue, 14 Jan 2025 17:11:16 -0500 X-MC-Unique: fNVoz8YDMMiv09T73PKnTQ-1 X-Mimecast-MFC-AGG-ID: fNVoz8YDMMiv09T73PKnTQ Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E2EC71955D83; Tue, 14 Jan 2025 22:11:12 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.50]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 8261519560AA; Tue, 14 Jan 2025 22:11:05 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 14 Jan 2025 23:10:47 +0100 (CET) Date: Tue, 14 Jan 2025 23:10:39 +0100 From: Oleg Nesterov To: Andrii Nakryiko Cc: Jiri Olsa , Aleksa Sarai , Eyal Birger , mhiramat@kernel.org, linux-kernel , linux-trace-kernel@vger.kernel.org, BPF-dev-list , Song Liu , Yonghong Song , John Fastabend , peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, x86@kernel.org, linux-api@vger.kernel.org, Andrii Nakryiko , Daniel Borkmann , Alexei Starovoitov , "rostedt@goodmis.org" , rafi@rbk.io, Shmulik Ladkani Subject: Re: Crash when attaching uretprobes to processes running in Docker Message-ID: <20250114221002.GA10122@redhat.com> References: <20250110.152323-sassy.torch.lavish.rent-vKX3ul5B3qyi@cyphar.com> <20250114105802.GA19816@redhat.com> <20250114203922.GA5051@redhat.com> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On 01/14, Andrii Nakryiko wrote: > > On Tue, Jan 14, 2025 at 12:40 PM Oleg Nesterov wrote: > > > > But, unlike sys_uretprobe(), sys_rt_sigreturn() is old, so the existing > > setups must know that sigreturn() should be respected... > > someday sys_uretprobe will be old as well ;) FWIW, systemd allowlisted > sys_uretprobe, see [0] And I agree! ;) I mean, I'd personally prefer to do nothing and wait until userspace figures out that we have another "special" syscall. But can we do it? I simply do not know. Can we ignore this (valid) bug report? Oleg.