From: Oleg Nesterov <oleg@redhat.com>
To: "Dmitry V. Levin" <ldv@strace.io>
Cc: Alexey Gladkov <legion@kernel.org>,
Eugene Syromyatnikov <evgsyr@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Renzo Davoli <renzo@cs.unibo.it>,
Davide Berardi <berardi.dav@gmail.com>,
strace-devel@lists.strace.io, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH v2 6/7] ptrace: introduce PTRACE_SET_SYSCALL_INFO request
Date: Wed, 15 Jan 2025 20:10:03 +0100 [thread overview]
Message-ID: <20250115191002.GC21801@redhat.com> (raw)
In-Reply-To: <20250115173642.GA25129@strace.io>
On 01/15, Dmitry V. Levin wrote:
>
> On Wed, Jan 15, 2025 at 05:38:09PM +0100, Oleg Nesterov wrote:
> >
> > But may be
> >
> > if (syscall_get_nr() != -1)
> > syscall_set_arguments(...);
> >
> > will look a bit more consistent?
>
> I'm sorry, but I didn't follow. As we've just set the syscall number with
> syscall_set_nr(), why would we want to call syscall_get_nr() right after
> that to obtain the syscall number?
Mostly for grep. We have more syscall_get_nr() != -1 checks. Even right after
syscall_set_nr-like code, see putreg32().
I think this needs another helper (which can have more users) and some cleanups.
But this is another issue, so please forget. I agree that syscall_get_nr() in
this code will probably just add the unnecessary confusion.
Oleg.
next prev parent reply other threads:[~2025-01-15 19:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250113170925.GA392@strace.io>
2025-01-13 17:12 ` [PATCH v2 6/7] ptrace: introduce PTRACE_SET_SYSCALL_INFO request Dmitry V. Levin
2025-01-15 16:38 ` Oleg Nesterov
2025-01-15 17:36 ` Dmitry V. Levin
2025-01-15 19:10 ` Oleg Nesterov [this message]
2025-01-16 1:55 ` Charlie Jenkins
2025-01-16 8:33 ` Dmitry V. Levin
2025-01-16 21:07 ` Charlie Jenkins
2025-01-16 21:47 ` Charlie Jenkins
2025-01-16 15:21 ` Oleg Nesterov
2025-01-16 16:04 ` Dmitry V. Levin
2025-01-16 16:40 ` Dmitry V. Levin
2025-01-17 14:45 ` Oleg Nesterov
2025-01-17 15:06 ` Dmitry V. Levin
2025-01-17 15:32 ` Oleg Nesterov
2025-01-17 16:22 ` Dmitry V. Levin
2025-01-18 14:13 ` Oleg Nesterov
2025-01-19 12:44 ` Dmitry V. Levin
2025-01-20 19:56 ` Oleg Nesterov
2025-01-19 14:38 ` Aleksa Sarai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115191002.GC21801@redhat.com \
--to=oleg@redhat.com \
--cc=berardi.dav@gmail.com \
--cc=evgsyr@gmail.com \
--cc=ldv@strace.io \
--cc=legion@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=renzo@cs.unibo.it \
--cc=strace-devel@lists.strace.io \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).