From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06DE31E0DDF for ; Wed, 29 Jan 2025 18:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738176778; cv=none; b=P6STWzMVboM3WZcbRksp9A8k3XPIHD5J0g3lqrTRYM2JNxhtJ30gexCPbpZmeTLjlOnQEya0y2Drv96UZCJ8VqAzrcNuurf8tlPojVarHTinNGvqiyYtdbA/Yy4n75npgxiyWyaguuceJTSCxLCCjljwd3AOf0PYzgC9vl2evSA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738176778; c=relaxed/simple; bh=kXUWf4bzCULNMipXU787lKMp83ROSa9zL6s2oSKQfIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PazzjqTotP3OTAP8rvHdnAucsuNAYy+Mp+VQpdNvpbCIqW3eHbN8eBXtElB4xKfjVg62Vt1LqosMUKAG/m54EnQ6v3sIq4AlsuKCtxEC/cz8xSyLF0Ke/P5vR8OHMG7bqfbD5r02pb/fHBxRDZnhADEh4zr4R1x0JhLR9wOIdj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=guS37h6U; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="guS37h6U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738176775; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vlOChQEKTp5JX+pbfAOT77vMe8ez+6+Y0ab8kJl+7mw=; b=guS37h6U4jQb8pnyZDcAbqU+6hNfrBBsu6memDDwG8F4+ZweCiSYuX6rZ/LMVveb70UlMa cMDU4BhhjyRfty7Xr7vPzqEMWujyjN4k0h6vI+sV/iXAImSVYSCMRFg0+eUwatbe1X3rq0 IPT0nGKZSPstsgmwswjwvOk09d/ZDOo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47--D-VqdZWMCuKFM53jcF7wQ-1; Wed, 29 Jan 2025 13:52:52 -0500 X-MC-Unique: -D-VqdZWMCuKFM53jcF7wQ-1 X-Mimecast-MFC-AGG-ID: -D-VqdZWMCuKFM53jcF7wQ Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 396CC19560BA; Wed, 29 Jan 2025 18:52:48 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.29]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 3326919560AA; Wed, 29 Jan 2025 18:52:16 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 29 Jan 2025 19:52:21 +0100 (CET) Date: Wed, 29 Jan 2025 19:51:49 +0100 From: Oleg Nesterov To: "Dmitry V. Levin" Cc: Alexey Gladkov , Charlie Jenkins , Eugene Syromyatnikov , Mike Frysinger , Renzo Davoli , Davide Berardi , strace-devel@lists.strace.io, Vineet Gupta , Russell King , Will Deacon , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Arnd Bergmann , Shuah Khan , linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v3 0/6] ptrace: introduce PTRACE_SET_SYSCALL_INFO API Message-ID: <20250129185149.GA25901@redhat.com> References: <20250128091445.GA8257@strace.io> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250128091445.GA8257@strace.io> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On 01/28, Dmitry V. Levin wrote: > > * ptrace: Add explicit padding to the end of struct ptrace_syscall_info, > simplify obtaining of user ptrace_syscall_info, > do not introduce PTRACE_SYSCALL_INFO_SIZE_VER0 > * ptrace: Change the return type of ptrace_set_syscall_info_* functions > from "unsigned long" to "int" > * ptrace: Add -ERANGE check to ptrace_set_syscall_info_exit, > add comments to -ERANGE checks > * ptrace: Update comments about supported syscall stops > * selftests: Extend set_syscall_info test, fix for mips n32 Again, I can't review 1-3, I know nothing about the non-x86 architectures. As for 4-6, feel free to add Reviewed-by: Oleg Nesterov