From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5EE31E5B65; Wed, 19 Feb 2025 14:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739974970; cv=none; b=KwfyKuuLDnQmyQw4pijbdqhHr8t8npFeDY2MLnHQxorSRl2y3XSBESOeQfCITcHj2XvgGekwmd7HfiuKYGR2L/LKEGqS9stFmRJvHBZQV/4E86NW5XRUYXYsaJl3wbHJ6/QYZXLGsdS1xEVmY3CbSL4x+Y7OpsQDn7ZCOHHkjDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739974970; c=relaxed/simple; bh=GTM0nMqLEseQqbskm/xMfNFu229ExtSbl6yk5KrJ6gI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m2e2FtALiyU0ALkGVkXGK5Ip6IZsG7k3ypPeaBpZr2op4kskxDJEpk1C55Kibky0ZhDBIwrg97/9Xhw6SmbJyvXd7C5H6diknRBnVrDKJ7BiB82//JX2gxOldfLZ/T+3U472NM2nPDc9T/8HFD6HsQJ4ookr+uyJwgGK3s5kybM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KvjMdccX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KvjMdccX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1ECCC4CED1; Wed, 19 Feb 2025 14:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739974969; bh=GTM0nMqLEseQqbskm/xMfNFu229ExtSbl6yk5KrJ6gI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KvjMdccXWY0mGNivdlQdAsrJ0unYr0odpSg0DzGNRRdmxH0mYIK43hTxK/ic0SumD 9hX2L8wNafdx57zHXjzMpsYnuuhDXJgdL9Vuz+hNDGrAXRMViLbpoy+KsZvWqol9wo OCk8TmnkV1n2KQUYRWf0Up+60IanHkiyQKaRJ02Q= Date: Wed, 19 Feb 2025 15:22:46 +0100 From: Greg Kroah-Hartman To: Elizabeth Figura Cc: dri-devel@lists.freedesktop.org, Arnd Bergmann , Jonathan Corbet , Shuah Khan , Mike Lothian , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, wine-devel@winehq.org, =?iso-8859-1?Q?Andr=E9?= Almeida , Wolfram Sang , Arkadiusz Hiler , Peter Zijlstra , Andy Lutomirski , Randy Dunlap , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng Subject: Re: [PATCH] ntsync: Set the permissions to be 0666 Message-ID: <2025021933-sureness-tipped-ff2b@gregkh> References: <20250214122759.2629-2-mike@fireburn.co.uk> <2768333.mvXUDI8C0e@camazotz> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2768333.mvXUDI8C0e@camazotz> On Tue, Feb 18, 2025 at 05:57:31PM -0600, Elizabeth Figura wrote: > On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote: > > This allows ntsync to be usuable by non-root processes out of the box > > > > Signed-off-by: Mike Lothian > > --- > > drivers/misc/ntsync.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c > > index 055395cde42b..586b86243e1d 100644 > > --- a/drivers/misc/ntsync.c > > +++ b/drivers/misc/ntsync.c > > @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = { > > .minor = MISC_DYNAMIC_MINOR, > > .name = NTSYNC_NAME, > > .fops = &ntsync_fops, > > + .mode = 0666, // Setting file permissions to 0666 > > }; > > > > module_misc_device(ntsync_misc); > > > > Reviewed-by: Elizabeth Figura > > -- > > The comment seems rather redundant, but otherwise this is correct and prudent. I agree, I'll drop the comment when I apply it, thanks. greg k-h