From: John Garry <john.g.garry@oracle.com>
To: brauner@kernel.org, djwong@kernel.org, hch@lst.de,
viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org
Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
ojaswin@linux.ibm.com, ritesh.list@gmail.com,
martin.petersen@oracle.com, linux-ext4@vger.kernel.org,
linux-block@vger.kernel.org, catherine.hoang@oracle.com,
linux-api@vger.kernel.org, John Garry <john.g.garry@oracle.com>
Subject: [PATCH v10 04/15] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomic_write()
Date: Thu, 1 May 2025 16:57:22 +0000 [thread overview]
Message-ID: <20250501165733.1025207-5-john.g.garry@oracle.com> (raw)
In-Reply-To: <20250501165733.1025207-1-john.g.garry@oracle.com>
In future we will want to be able to check if specifically HW offload-based
atomic writes are possible, so rename xfs_inode_can_atomicwrite() ->
xfs_inode_can_hw_atomicwrite().
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
[djwong: add an underscore to be consistent with everything else]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
fs/xfs/xfs_file.c | 2 +-
fs/xfs/xfs_inode.h | 2 +-
fs/xfs/xfs_iops.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 84f08c976ac4..55bdae44e42a 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -1488,7 +1488,7 @@ xfs_file_open(
if (xfs_is_shutdown(XFS_M(inode->i_sb)))
return -EIO;
file->f_mode |= FMODE_NOWAIT | FMODE_CAN_ODIRECT;
- if (xfs_inode_can_atomicwrite(XFS_I(inode)))
+ if (xfs_inode_can_hw_atomic_write(XFS_I(inode)))
file->f_mode |= FMODE_CAN_ATOMIC_WRITE;
return generic_file_open(inode, file);
}
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
index eae0159983ca..bdbbff0d8d99 100644
--- a/fs/xfs/xfs_inode.h
+++ b/fs/xfs/xfs_inode.h
@@ -357,7 +357,7 @@ static inline bool xfs_inode_has_bigrtalloc(const struct xfs_inode *ip)
(ip)->i_mount->m_rtdev_targp : (ip)->i_mount->m_ddev_targp)
static inline bool
-xfs_inode_can_atomicwrite(
+xfs_inode_can_hw_atomic_write(
struct xfs_inode *ip)
{
struct xfs_mount *mp = ip->i_mount;
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index f0e5d83195df..22432c300fd7 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -608,7 +608,7 @@ xfs_report_atomic_write(
{
unsigned int unit_min = 0, unit_max = 0;
- if (xfs_inode_can_atomicwrite(ip))
+ if (xfs_inode_can_hw_atomic_write(ip))
unit_min = unit_max = ip->i_mount->m_sb.sb_blocksize;
generic_fill_statx_atomic_writes(stat, unit_min, unit_max, 0);
}
--
2.31.1
next prev parent reply other threads:[~2025-05-01 16:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 16:57 [PATCH v10 00/15] large atomic writes for xfs John Garry
2025-05-01 16:57 ` [PATCH v10 01/15] fs: add atomic write unit max opt to statx John Garry
2025-05-02 20:12 ` [PATCH v10.1 1.1/15] xfs: only call xfs_setsize_buftarg once per buffer target Darrick J. Wong
2025-05-01 16:57 ` [PATCH v10 02/15] xfs: add helpers to compute log item overhead John Garry
2025-05-01 16:57 ` [PATCH v10 03/15] xfs: add helpers to compute transaction reservation for finishing intent items John Garry
2025-05-01 16:57 ` John Garry [this message]
2025-05-01 16:57 ` [PATCH v10 05/15] xfs: ignore HW which cannot atomic write a single block John Garry
2025-05-02 20:13 ` [PATCH v10.1 " Darrick J. Wong
2025-05-01 16:57 ` [PATCH v10 06/15] xfs: allow block allocator to take an alignment hint John Garry
2025-05-01 16:57 ` [PATCH v10 07/15] xfs: refactor xfs_reflink_end_cow_extent() John Garry
2025-05-01 16:57 ` [PATCH v10 08/15] xfs: refine atomic write size check in xfs_file_write_iter() John Garry
2025-05-01 16:57 ` [PATCH v10 09/15] xfs: add xfs_atomic_write_cow_iomap_begin() John Garry
2025-05-01 16:57 ` [PATCH v10 10/15] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin() John Garry
2025-05-01 16:57 ` [PATCH v10 11/15] xfs: commit CoW-based atomic writes atomically John Garry
2025-05-01 16:57 ` [PATCH v10 12/15] xfs: add xfs_file_dio_write_atomic() John Garry
2025-05-01 16:57 ` [PATCH v10 13/15] xfs: add xfs_calc_atomic_write_unit_max() John Garry
2025-05-05 5:22 ` Darrick J. Wong
2025-05-01 16:57 ` [PATCH v10 14/15] xfs: update atomic write limits John Garry
2025-05-01 16:57 ` [PATCH v10 15/15] xfs: allow sysadmins to specify a maximum atomic write limit at mount time John Garry
2025-05-01 19:52 ` [PATCH 16/15] xfs: only call xfs_setsize_buftarg once per buffer target Darrick J. Wong
2025-05-02 6:57 ` Christoph Hellwig
2025-05-02 16:44 ` Darrick J. Wong
2025-05-01 19:53 ` [PATCH 17/15] xfs: move buftarg atomic write geometry config to setsize_buftarg Darrick J. Wong
2025-05-02 6:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501165733.1025207-5-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).