From: Askar Safin <safinaskar@gmail.com>
To: cyphar@cyphar.com
Cc: alx@kernel.org, brauner@kernel.org, dhowells@redhat.com,
g.branden.robinson@gmail.com, jack@suse.cz,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-man@vger.kernel.org,
mtk.manpages@gmail.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v5 7/8] man/man2/open_tree{,_attr}.2: document new open_tree_attr() API
Date: Wed, 1 Oct 2025 03:38:41 +0300 [thread overview]
Message-ID: <20251001003841.510494-1-safinaskar@gmail.com> (raw)
In-Reply-To: <20250925-new-mount-api-v5-7-028fb88023f2@cyphar.com>
Aleksa Sarai <cyphar@cyphar.com>:
> +mntfd2 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> + &attr, sizeof(attr));
Your whole so-called "open_tree_attr example" doesn't contain any open_tree_attr
calls. :)
I think you meant open_tree_attr here.
> +\&
> +/* Create a new copy with the id-mapping cleared */
> +memset(&attr, 0, sizeof(attr));
> +attr.attr_clr = MOUNT_ATTR_IDMAP;
> +mntfd3 = open_tree(mntfd1, "", OPEN_TREE_CLONE,
> + &attr, sizeof(attr));
And here.
Otherwise your whole patchset looks good. Add to whole patchset:
Reviewed-by: Askar Safin <safinaskar@gmail.com>
--
Askar Safin
next prev parent reply other threads:[~2025-10-01 0:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 15:31 [PATCH v5 0/8] man2: document "new" mount API Aleksa Sarai
2025-09-24 15:31 ` [PATCH v5 1/8] man/man2/fsopen.2: " Aleksa Sarai
2025-09-25 10:13 ` Alejandro Colomar
2025-09-24 15:31 ` [PATCH v5 2/8] man/man2/fspick.2: " Aleksa Sarai
2025-09-25 11:14 ` Alejandro Colomar
2025-09-24 15:31 ` [PATCH v5 3/8] man/man2/fsconfig.2: " Aleksa Sarai
2025-09-25 11:32 ` Alejandro Colomar
2025-09-25 15:15 ` Aleksa Sarai
2025-09-25 16:52 ` Alejandro Colomar
2025-09-26 12:48 ` Alejandro Colomar
2025-09-24 15:31 ` [PATCH v5 4/8] man/man2/fsmount.2: " Aleksa Sarai
2025-09-26 12:51 ` Alejandro Colomar
2025-09-24 15:31 ` [PATCH v5 5/8] man/man2/move_mount.2: " Aleksa Sarai
2025-09-26 12:56 ` Alejandro Colomar
2025-09-24 15:31 ` [PATCH v5 6/8] man/man2/open_tree.2: " Aleksa Sarai
2025-10-01 17:59 ` Alejandro Colomar
2025-09-24 15:31 ` [PATCH v5 7/8] man/man2/open_tree{,_attr}.2: document new open_tree_attr() API Aleksa Sarai
2025-10-01 0:38 ` Askar Safin [this message]
2025-10-01 6:45 ` Alejandro Colomar
2025-10-01 7:37 ` Aleksa Sarai
2025-10-01 7:35 ` Aleksa Sarai
2025-10-01 18:02 ` Alejandro Colomar
2025-10-03 4:22 ` Aleksa Sarai
2025-09-24 15:31 ` [PATCH v5 8/8] man/man2/{fsconfig,mount_setattr}.2: add note about attribute-parameter distinction Aleksa Sarai
2025-10-01 18:20 ` [PATCH v5 0/8] man2: document "new" mount API Alejandro Colomar
2025-10-26 12:27 ` Askar Safin
2025-10-26 17:27 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001003841.510494-1-safinaskar@gmail.com \
--to=safinaskar@gmail.com \
--cc=alx@kernel.org \
--cc=brauner@kernel.org \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=g.branden.robinson@gmail.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).