From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-42a9.mail.infomaniak.ch (smtp-42a9.mail.infomaniak.ch [84.16.66.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B84D8369231 for ; Tue, 20 Jan 2026 21:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.16.66.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768946114; cv=none; b=YB7GUERjXHmBs16H+2R+4/44mRVGfLMzRpFBGXgbCDBkB97RriC9p5wfrh+pKXIqiESCQwReieXOtUS0Z/6vKIRteuvnljbp9Pl4bSJyTOjouckUIcTVxLcyEaKAyh3saDbRvZeFY2gsApkX9/Lm+6B7gR1IcltAQ/U63P7ACH0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768946114; c=relaxed/simple; bh=AwHUD+rXuhKyKmXPrdQZrRAZDbCQlrWch9VuSW3eH3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W8op/AmZ5zC1Ln25+c7qYd2jsBdF3xPQPydrzPSj2Xe+vke5i53F3Xb9CChnD36giTia02jv3XhtG1M4xu8Ls0P3CW6wEfObxMF+6Ci56cN9huQY7fYVGy0O8T38enACsi0JrXTjrhCgtCe6LERW24cTQFKi+IejjOZUrFs+dnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=WcCwNIfl; arc=none smtp.client-ip=84.16.66.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="WcCwNIfl" Received: from smtp-4-0001.mail.infomaniak.ch (unknown [IPv6:2001:1600:7:10::a6c]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4dwgrd52Bmzg9t; Tue, 20 Jan 2026 22:46:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digikod.net; s=20191114; t=1768945601; bh=CUnC6gBg1b8DZjIFRJjoz21kw+O4IDvw1ZCQ7hb32w0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WcCwNIfltvas3I8WkaxOw4+8cb98Kkmo+ZF7qsZUr3tX3je8MAfeFMOjr92TJkrD7 XHcq1YNheRGDGLozfVE6lbHz+Sh1sEIyypT2HGH9iGOunB8tq0HyME1MLnr3r6W7tB iUtAbnd0WOsULgDiW94Mr0CTZWRkmIpnuHhdLSR0= Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4dwgrb45vZzqrp; Tue, 20 Jan 2026 22:46:39 +0100 (CET) Date: Tue, 20 Jan 2026 22:46:34 +0100 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Cc: Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Shuah Khan , Matthieu Baerts , Mat Martineau , Geliang Tang , =?utf-8?Q?G=C3=BCnther?= Noack , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, libc-alpha@sourceware.org, Carlos O'Donell , Adhemerval Zanella , Rich Felker , klibc@zytor.com, Florian Weimer Subject: Re: [PATCH net-next v2 2/4] selftests/landlock: Move some UAPI header inclusions after libc ones Message-ID: <20260120.ahGaepheZah8@digikod.net> References: <20260120-uapi-sockaddr-v2-0-63c319111cf6@linutronix.de> <20260120-uapi-sockaddr-v2-2-63c319111cf6@linutronix.de> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260120-uapi-sockaddr-v2-2-63c319111cf6@linutronix.de> X-Infomaniak-Routing: alpha On Tue, Jan 20, 2026 at 03:10:32PM +0100, Thomas Weißschuh wrote: > Interleaving inclusions of UAPI headers and libc headers is problematic. > Both sets of headers define conflicting symbols. To enable their > coexistence a compatibility-mechanism is in place. > > An upcoming change will define 'struct sockaddr' from linux/socket.h. > However sys/socket.h from libc does not yet handle this case and a > symbol conflict will arise. > > Move the inclusion of all UAPI headers after the inclusion of the glibc > ones, so the compatibility mechanism from the UAPI headers is used. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Mickaël Salaün Thanks! > --- > tools/testing/selftests/landlock/audit.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/landlock/audit.h b/tools/testing/selftests/landlock/audit.h > index 44eb433e9666..c12b16c690dc 100644 > --- a/tools/testing/selftests/landlock/audit.h > +++ b/tools/testing/selftests/landlock/audit.h > @@ -7,9 +7,6 @@ > > #define _GNU_SOURCE > #include > -#include > -#include > -#include > #include > #include > #include > @@ -20,6 +17,10 @@ > #include > #include > > +#include > +#include > +#include > + > #include "kselftest.h" > > #ifndef ARRAY_SIZE > > -- > 2.52.0 > >