From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793498246; b=YyqIbt/liRK8MEONXfwmhgTDct2U8zc70F+VonjQY8+uh+pSoNDzckPZycvyaB1QRLSq ovOcCQInKQfyLJom2MDa1iaxCwkIlOqwIMPBMXkjQ+Ds4UrsRoIzc8k9y+tC5Dj97+3KB XehUyxMq0ZpJJfvC9utNH3iVjWFg2RbByhK9eImvLuN5QLXegUtoLKTJCt8MIEvt57QNC YaXCPX9oqamzEfaR8oXfJuxm7IDY8hoNQXdqZI5GXFMc2lAvzHaWIuowpvUUs3mcNVw3x Cn+lgB90F2epKWBIaT1Zydmdxhx+trb3EhHiSBdk9znHhGyDdwjzO7Q2wwr2vl3zVvg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793498246; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=9AHT+4uPvWe1t1h3zSSbp4rofXCcWo8UcjGq3mTB8UM=; b=cYg6OvVp2hXMi1IArE5CJsPV86RdhrLaHL1xVXFqeb4RRrvcI6wgzmv26x/pjDkFclPy U/M6wsRJKLjT/+aGNNB8YJmrU61o7RDX/JoM810IfXatAPiig6aubSUxz+Nc+ocP9PX8i IDivXzeyOGfsEZ6RpIvLlCF1WILeivflFqZJboekzMYJXyH1ZITYleQdsnw6j32uqKSWG /YhVgES3m4fDgS9jI2siQj+0VB5JrkEMkaEV5XF40autJ3kxFo1x4uOwWcs5aj5CeDR7v o2mxP9zip27KLjhlB/99U6B+MUW6E1NijySFGGyMHWihzsG8YyUCzfn/3rb8CWCwEDg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=c6E9zXny; arc=none smtp.remote-ip=209.85.128.41 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CB7660A2627 for ; Sun, 1 Nov 2026 01:57:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5CB7660A2627 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=c6E9zXny Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4a4d7ae1ae9so17480905e9.1 for ; Sat, 31 Oct 2026 18:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793498245; x=1794103045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9AHT+4uPvWe1t1h3zSSbp4rofXCcWo8UcjGq3mTB8UM=; b=c6E9zXnyBd1dxj3QVODEevFQOkW9llb0HZ5WHJHiNOiNB9qd6qEdsxAiD88lBYRUhy RTD8dwAyeeMQ/P6e4XpBTyYr9CdHq1Z5ZoSjnOcQ43l0sSRRE2SU2bVaKSbP7OFiU5am +YnZ3xy+tatzzdG5jV5qTqox0i5Za2dg053/k5zKoz9m5X4KZjO30QPe4vk/Rih8omDj kkesHih7L7GwtKXoIlBExVUv6BuqM4MvhmN4pXiSiKn33VEAT1eS/KXlb8GZySTFSi63 R6NVPFry/yoaz8fuwwf1PLpHwOl3hFTsQpXDci8LWS15HRCyP5IWZVyH9IoPaEqPzTYF IT9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793498245; x=1794103045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9AHT+4uPvWe1t1h3zSSbp4rofXCcWo8UcjGq3mTB8UM=; b=KUGVykW3Q3L9XdDUjIx+cMZcUnbTf8dfDo2O720bLLSUXI1LEXVA00OC8Sm3tan7LZ jUkEFiPH9NSMkb7OiJ24vfCtBVRP3lgpeTSoWgMFihiiPtUAsQFnEuSFZY/Pe76xZoSb DPXGVfZrv4hkKELCK/Ip4BYT+CaK0aDQ9Pn9H2kUcpPZqZkPa4WoLc1arwxX5b+AmSqF IJFrRyzc57g7PgQ+ExjZrlyY4XbC4OJNu9rvWqjAQqIlIE2qCXbsNPbN6GTUFOjzHy/Y Zbzd7UtXRe2hQBvkOiZjBmt5O49sDZXkDc7FCAU6KhYaq01dnQMAnwKs7j+cskogm15M jPag== X-Forwarded-Encrypted: i=1; AKwUvBx7EsyRGs77wfiNtXDDNW8WZDBG2vy4vZ2cwUAdIS/VVojXXgfZxGca6bBAXcCCUNJ0L26ii8dh77o=@vger.kernel.org X-Gm-Message-State: AFq9FYJ1e9FzKv2Z9Q9IxpiAKqK9CxbqggnueO8qNAz6vVSJwK6GXo/S m5wo1hg5sakZ2Foa7BENzue2Vd+Lo/X8IA8O7vqgaBac7gItavrR4wEI X-Gm-Gg: AYBFou310E2tk3fBXCUHqLU4+8WQ7p4fQvSUtOj4HVYTvnDE26h/sM0Zddyk46unCl7 MBZxTXvUqqi21r7VbKrI7xHb/dXE+IsoqsN8FDyHPsiHAYKB+/Us3uoaCKwfL7vHZD/imTvnhC/ tRDeieMLNAlEgcfLPXup7JATFFObt02D0sw8Vq0iuBhEsQcdEYIYh/ZNMhdw/tI0WiD7/yaURfy Ts86QTWfDsfsyetyHanSBpTNDPD3HtvDfmaMat5gFpQ/S5PvAMeIM/+SC671SPHP90zzA29crSY b0bLEook/+5daxrgab7yOb9usnsZN8Vd1CUlo7ibUF+t6Q+5f7/YB/nK1A6Jq81mnKLoFZO787h n58cYU9rpjpssycyrAt3+xir1LUyVlffXi2l21waoDOFVm/k4aKfhbPsSMGTaFb1XD5CEorK8Hl CALySa/0tqBNEto+1WnK7uU14D+v3SzSn/p+lYcp5imnRFFWF0cen6MzXWyMOdnKTwxBQHh0WKO BHWN4poQwbKN3k2ET0cBila+cCtqp4gDj5Ml5q6vguBBtj/X6L/zfTbTsKs98ECI3OZRDtQVojd pAbo4jUfKgMVXI2VIgkY9zwv X-Received: by 2002:a05:600c:3ba0:b0:4a1:e0db:8cf8 with SMTP id 5b1f17b1804b1-4ac151a84f0mr142228025e9.3.1793498244682; Sat, 31 Oct 2026 18:57:24 -0700 (PDT) Received: from infinity ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4aa81b7fe80sm273532835e9.11.2026.10.31.18.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Oct 2026 18:57:23 -0700 (PDT) From: koraynilay To: David Sterba , Alexander Viro , Christian Brauner , Namjae Jeon , Sungjong Seo , Konstantin Komarov Cc: Chris Mason , Jan Kara , Yuezhang Mo , Chuck Lever , "Darrick J . Wong" , Sean Smith , Andrey Albershteyn , Pedro Falcato , Amir Goldstein , =?UTF-8?q?Pali=20Roh=C3=A1r?= , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, exfat@lists.linux.dev, ntfs3@lists.linux.dev, linux-api@vger.kernel.org, koraynilay Subject: [RFC PATCH v3 2/5] vfs: add fileattr_has_fsx_mask() Date: Sun, 1 Nov 2026 02:55:48 +0100 Message-ID: <20261101015551.786044-3-koray.fra@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261101015551.786044-1-koray.fra@gmail.com> References: <20261101015551.786044-1-koray.fra@gmail.com> X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add fileattr_has_fsx_mask() as a helper to let filesystems check for unsupported xflags while allowing supported ones. Can be used in the same way as fileattr_has_fsx(). Also make fileattr_has_fsx() a wrapper around fileattr_has_fsx_mask(). Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.4.7 Signed-off-by: koraynilay --- include/linux/fileattr.h | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h index 0b93f9609284..16acc61c9af1 100644 --- a/include/linux/fileattr.h +++ b/include/linux/fileattr.h @@ -64,6 +64,23 @@ int copy_fsxattr_to_user(const struct file_kattr *fa, struct fsxattr __user *ufa void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags); void fileattr_fill_flags(struct file_kattr *fa, u32 flags); +/** + * fileattr_has_fsx_mask - check for extended flags/attributes + * @fa: fileattr pointer + * @allowed_xflags_mask: additional xflags permitted + * + * Return: true if any attributes are present that are not represented in + * ->flags or @allowed_xflags_mask. + */ +static inline bool fileattr_has_fsx_mask(const struct file_kattr *fa, + u32 allowed_xflags_mask) +{ + return fa->fsx_valid && + ((fa->fsx_xflags & ~(FS_XFLAG_COMMON | allowed_xflags_mask)) || + fa->fsx_extsize != 0 || fa->fsx_projid != 0 || + fa->fsx_cowextsize != 0); +} + /** * fileattr_has_fsx - check for extended flags/attributes * @fa: fileattr pointer @@ -73,9 +90,7 @@ void fileattr_fill_flags(struct file_kattr *fa, u32 flags); */ static inline bool fileattr_has_fsx(const struct file_kattr *fa) { - return fa->fsx_valid && - ((fa->fsx_xflags & ~FS_XFLAG_COMMON) || fa->fsx_extsize != 0 || - fa->fsx_projid != 0 || fa->fsx_cowextsize != 0); + return fileattr_has_fsx_mask(fa, 0); } int vfs_fileattr_get(struct dentry *dentry, struct file_kattr *fa); -- 2.56.0