Linux userland API discussions
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Christian Brauner <brauner@kernel.org>
Cc: Cai Xinchen <caixinchen1@huawei.com>,
	mic@digikod.net, gnoack@google.com, paul@paul-moore.com,
	jack@suse.cz, amir73il@gmail.com, andrii@kernel.org,
	apparmor@lists.ubuntu.com, ast@kernel.org, axboe@kernel.dk,
	bpf@vger.kernel.org, casey@schaufler-ca.com, cel@kernel.org,
	cem@kernel.org, chenxiaosong@chenxiaosong.com, code@tyhicks.com,
	corbet@lwn.net, Dai.Ngo@oracle.com, dakr@kernel.org,
	daniel@iogearbox.net, dhowells@redhat.com, dlemoal@kernel.org,
	dmitry.kasatkin@gmail.com, driver-core@lists.linux.dev,
	dsterba@suse.com, ecryptfs@vger.kernel.org, eddyz87@gmail.com,
	emil@etsalapatis.com, eric.snowberg@oracle.com,
	exfat@lists.linux.dev, georgia.garcia@canonical.com,
	gregkh@linuxfoundation.org, hch@lst.de,
	hirofumi@mail.parknet.co.jp, hyc.lee@gmail.com,
	ihor.solodrai@linux.dev, jlayton@kernel.org, jmorris@namei.org,
	johan@kernel.org, john.fastabend@gmail.com,
	john.johansen@canonical.com, jolsa@kernel.org,
	kpsingh@kernel.org, linkinjeon@kernel.org,
	linux-api@vger.kernel.org, linux-block@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org,
	liubaolin12138@163.com, martin.lau@linux.dev, mason@kernel.org,
	mathieu.desnoyers@efficios.com, matt@bobrowski.net,
	memxor@gmail.com, mhiramat@kernel.org, miklos@szeredi.hu,
	neil@brown.name, netfs@lists.linux.dev, ntfs@lists.linux.dev,
	okorniev@redhat.com, omosnacek@gmail.com,
	penguin-kernel@i-love.sakura.ne.jp, rafael@kernel.org,
	rdunlap@infradead.org, roberto.sassu@huawei.com,
	rostedt@goodmis.org, selinux@vger.kernel.org,
	senozhatsky@chromium.org, serge@hallyn.com,
	sj1557.seo@samsung.com, skhan@linuxfoundation.org,
	song@kernel.org, stephen.smalley.work@gmail.com,
	takedakn@nttdata.co.jp, tom@talpey.com, yonghong.song@linux.dev,
	yuezhang.mo@sony.com, zohar@linux.ibm.com,
	utilityemal77@gmail.com, lujialin4@huawei.com
Subject: Re: [PATCH -next -v4 02/17] LSM: pass struct path to the inode_setsecctx hook
Date: Thu, 19 Nov 2026 05:51:26 +0000	[thread overview]
Message-ID: <20261119055126.GU989762@ZenIV> (raw)
In-Reply-To: <20261118-woher-duften-bejubeln-7a8a2099f89f@brauner>

On Wed, Nov 18, 2026 at 09:51:27AM +0100, Christian Brauner wrote:
> On Wed, Nov 18, 2026 at 12:16:41AM +0000, Al Viro wrote:
> > On Tue, Nov 17, 2026 at 06:43:42PM +0000, Al Viro wrote:
> > > > + * Hooks that take a struct path argument: the VFS only sanctions passing
> > > > + * the path to VFS helpers that take a struct path (e.g. notify_change());
> > > > + * it makes no guarantees with regard to path->mnt, whose layout and
> > > > + * implementation details are subject to change.  Implementations must
> > > > + * not rely on its properties.
> 
> That comment is a garbled version of an earlier review. It meant that
> LSMs get no guarantees about struct vfsmount internals and don't get to
> poke at them. I'm not sure how this can be read as path->mnt being a
> random mount.

"no guarantees with regard to path->mnt" is easy to parse that way when one
is stuck with a caller that needs to be converted to new API with no relevant
mount reference in sight.

> > > If that kind of stuff actually does get passed to any existing hooks, we need
> > > to fix that ASAP.
> 
> Of course there is one...
> 
>   dent = lookup_one_unlocked(idmap, &QSTR_LEN(...),
>                              priv->dir_fp->filp->f_path.dentry);
>   [...].
>   rc = ksmbd_vfs_fill_dentry_attrs(priv->work, idmap, dent, &ksmbd_kstat);
> 
> It passes only the bare dentry, and ksmbd_vfs_fill_dentry_attrs() then
> makes up a path from the share's root mount:
> 
>   struct path path = {
>           .mnt = share_conf->vfs_path.mnt,   /* mount the share is exported from */
>           .dentry = dentry,                  /* entry inside the listed dir */
>   };
>   rc = vfs_getattr(&path, ...);
> 
> since 5614c8c487f6 ("ksmbd: replace generic_fillattr with vfs_getattr").
> 
> So a client that lists a directory on a submount below the share then
> that dentry belongs to another superblock. So security_inode_getattr()
> and ->getattr() get a mixed path.

So e.g. apparmor hits
        vfsuid_t vfsuid = i_uid_into_vfsuid(mnt_idmap(path->mnt),
					    d_backing_inode(path->dentry));
with path->mnt having nothing to do with path->dentry there?  Fun...

> The third patch in this series fixes this. But we should make this a
> Fixes: patch really... Something like [1].
> 
> > To elaborate a bit: correctness of quite a few places does depend upon the
> > following invaraint:
> > 	path->mnt->mnt_sb == path->dentry->d_sb		(1)
> > for all struct path pointers they might possibly run into.
> >
> > _IF_ you can guarantee that (1) is not violated, we have something to
> > talk about; otherwise, don't call your object struct path and don't
> > pass it to anything that expects to deal with struct path.
> 
> Every struct path the series constructs:
> 
>   - devtmpfs
>   - nfsd
>   - cachefiles
>   - ecryptfs
>   - overlayfs
>   - ksmbd
> 
> doesn't have this bug.
> 
> [1]:
> 
>   --- a/fs/smb/server/smb2pdu.c
>   +++ b/fs/smb/server/smb2pdu.c
>   @@ -6375,13 +6375,14 @@ static int process_query_dir_entries(struct smb2_query_dir_private *priv)
>                           continue;
>                   }
> 
>   +               path.mnt = priv->dir_fp->filp->f_path.mnt;
>   +               path.dentry = dent;
>   +
>                   if (test_share_config_flag(priv->work->tcon->share_conf,
>                                              KSMBD_SHARE_FLAG_HIDE_UNREADABLE)) {
>                           __le32 daccess = FILE_READ_DATA_LE | FILE_READ_EA_LE |
>                                   FILE_READ_ATTRIBUTES_LE;
> 
>   -                       path.mnt = priv->dir_fp->filp->f_path.mnt;
>   -                       path.dentry = dent;
>                           rc = smb_check_perm_dacl(priv->work->conn, &path,
>                                                    &daccess, daccess,
>                                                    priv->work->sess->user->uid,
>   @@ -6397,7 +6398,7 @@ static int process_query_dir_entries(struct smb2_query_dir_private *priv)
>   @@ -6397,7 +6398,7 @@ static int process_query_dir_entries(struct smb2_query_dir_private *priv)
>                   if (priv->info_level != FILE_NAMES_INFORMATION) {
>                           rc = ksmbd_vfs_fill_dentry_attrs(priv->work,
>                                                            idmap,
>   -                                                        dent,
>   +                                                        &path,
>                                                            &ksmbd_kstat);
>                           if (rc) {
>                                   dput(dent);
>   --- a/fs/smb/server/smb_common.c
>   +++ b/fs/smb/server/smb_common.c
>   @@ -472,32 +472,36 @@ int ksmbd_populate_dot_dotdot_entries(struct ksmbd_work *work, int info_level,
>           for (i = 0; i < 2; i++) {
>                   struct kstat kstat;
>                   struct ksmbd_kstat ksmbd_kstat;
>   -               struct dentry *dentry;
>   +               struct path path = { .mnt = dir->filp->f_path.mnt };

That's just asking for breakage down the road.  Just pass it
the address of ->f_path for "." and
	&(struct path){.mnt = dir->filp->f_path.mnt, .dentry = dentry}
for ".." (and sod the dentry = dget(...) for "." - just have it NULL there)

  reply	other threads:[~2026-11-19  5:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:05 [PATCH -next -v4 00/17] landlock: Add READ_METADATA and WRITE_METADATA access rights Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 01/17] fs: pass struct path to notify_change() Cai Xinchen
2026-11-17 18:30   ` Al Viro
2026-11-17 18:34     ` Al Viro
2026-11-18  9:17       ` Cai Xinchen
2026-11-18  9:13     ` Cai Xinchen
2026-11-19  5:23       ` Al Viro
2026-11-17 15:05 ` [PATCH -next -v4 02/17] LSM: pass struct path to the inode_setsecctx hook Cai Xinchen
2026-11-17 18:43   ` Al Viro
2026-11-18  0:16     ` Al Viro
2026-11-18  8:51       ` Christian Brauner
2026-11-19  5:51         ` Al Viro [this message]
2026-11-18  8:59       ` Cai Xinchen
2026-11-18  9:35         ` Christian Brauner
2026-11-19  3:46           ` Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 03/17] fs: pass struct path to xattr helpers Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 04/17] fs: pass struct path to POSIX ACL helpers Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 05/17] LSM: pass struct path and struct file to the inode xattr hooks Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 06/17] LSM: pass struct path and struct file to the inode posix acl hooks Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 07/17] LSM: pass struct path and struct file to the inode fileattr hooks Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 08/17] LSM: rename inode_setattr to path_setattr and pass struct path and file Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 09/17] LSM: rename inode_getattr to path_getattr and pass struct file Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 10/17] LSM: rename the inode xattr hooks to path_xattr hooks Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 11/17] LSM: rename the inode posix acl hooks to path_*_acl hooks Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 12/17] LSM: rename the inode fileattr hooks to path_file_* hooks Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 13/17] LSM: rename inode_setsecctx to path_setsecctx Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 14/17] landlock: Add READ_METADATA and WRITE_METADATA access rights Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 15/17] selftests/landlock: Add tests for metadata " Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 16/17] samples/landlock: Add metadata rights to sandboxer Cai Xinchen
2026-11-17 15:05 ` [PATCH -next -v4 17/17] Documentation: Update landlock doc for metadata rights Cai Xinchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119055126.GU989762@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=Dai.Ngo@oracle.com \
    --cc=amir73il@gmail.com \
    --cc=andrii@kernel.org \
    --cc=apparmor@lists.ubuntu.com \
    --cc=ast@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=caixinchen1@huawei.com \
    --cc=casey@schaufler-ca.com \
    --cc=cel@kernel.org \
    --cc=cem@kernel.org \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=code@tyhicks.com \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dhowells@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=driver-core@lists.linux.dev \
    --cc=dsterba@suse.com \
    --cc=ecryptfs@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=eric.snowberg@oracle.com \
    --cc=exfat@lists.linux.dev \
    --cc=georgia.garcia@canonical.com \
    --cc=gnoack@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=hyc.lee@gmail.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=jmorris@namei.org \
    --cc=johan@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=john.johansen@canonical.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=liubaolin12138@163.com \
    --cc=lujialin4@huawei.com \
    --cc=martin.lau@linux.dev \
    --cc=mason@kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=matt@bobrowski.net \
    --cc=memxor@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=mic@digikod.net \
    --cc=miklos@szeredi.hu \
    --cc=neil@brown.name \
    --cc=netfs@lists.linux.dev \
    --cc=ntfs@lists.linux.dev \
    --cc=okorniev@redhat.com \
    --cc=omosnacek@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=roberto.sassu@huawei.com \
    --cc=rostedt@goodmis.org \
    --cc=selinux@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=serge@hallyn.com \
    --cc=sj1557.seo@samsung.com \
    --cc=skhan@linuxfoundation.org \
    --cc=song@kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=takedakn@nttdata.co.jp \
    --cc=tom@talpey.com \
    --cc=utilityemal77@gmail.com \
    --cc=yonghong.song@linux.dev \
    --cc=yuezhang.mo@sony.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox