From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Desnoyers Subject: Re: [RFC PATCH v2 1/3] getcpu_cache system call: cache CPU number of running thread Date: Wed, 27 Jan 2016 17:36:48 +0000 (UTC) Message-ID: <2049061625.6140.1453916208296.JavaMail.zimbra@efficios.com> References: <1453913683-28915-1-git-send-email-mathieu.desnoyers@efficios.com> <1453913683-28915-2-git-send-email-mathieu.desnoyers@efficios.com> <20160127172044.GA7514@cloud> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thomas Gleixner Cc: Josh Triplett , Paul Turner , Andrew Hunter , Peter Zijlstra , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api , Andy Lutomirski , Andi Kleen , Dave Watson , Chris Lameter , Ingo Molnar , Ben Maurer , rostedt , "Paul E. McKenney" , Linus Torvalds , Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Michael Kerrisk List-Id: linux-api@vger.kernel.org ----- On Jan 27, 2016, at 12:24 PM, Thomas Gleixner tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org wrote: > On Wed, 27 Jan 2016, Josh Triplett wrote: >> With the dynamic allocation removed, this seems sensible to me. One >> minor nit: s/int32_t/uint32_t/g, since a location intended to hold a CPU >> number should never need to hold a negative number. > > You try to block the future of computing: https://lwn.net/Articles/638673/ Besides impossible architectures, there is actually a use-case for signedness here. It makes it possible to initialize the cpu number cache to a negative value, e.g. -1, in userspace. Then, a check for value < 0 can be used to figure out cases where the getcpu_cache system call is not implemented, and where a fallback (vdso or getcpu syscall) needs to be used. This is why I have chosen a signed type for the cpu cache so far. Thoughts ? Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com