From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriele Mazzotta Subject: Re: [PATCH] Documentation: Add entry for dell-laptop sysfs interface Date: Sat, 10 Jan 2015 14:08:11 +0100 Message-ID: <2495157.bRb6NIzxPV@xps13> References: <1417628493-29323-1-git-send-email-gabriele.mzt@gmail.com> <1636595.UbTko9mUNA@xps13> <20150110065714.GB104814@vmdeb7> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150110065714.GB104814@vmdeb7> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Darren Hart Cc: Brian Norris , mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, libsmbios-devel-XtjxT7Vmt5ZskZv2Y/7f+AC/G2K4zDHf@public.gmane.org, Srinivas_G_Gowda-8PEkshWhKlo@public.gmane.org, Michael_E_Brown-8PEkshWhKlo@public.gmane.org, pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, A.Sloman-dxBOTFGcEFw2EctHIo1CcQ@public.gmane.org List-Id: linux-api@vger.kernel.org On Friday 09 January 2015 22:57:14 Darren Hart wrote: > On Wed, Dec 31, 2014 at 12:20:59PM +0100, Gabriele Mazzotta wrote: > > On Tuesday 30 December 2014 21:31:49 Brian Norris wrote: > > > Hi, > > >=20 > > > On Wed, Dec 03, 2014 at 06:41:33PM +0100, Gabriele Mazzotta wrote= : > > > > Add the documentation for the new sysfs interface of dell-lapto= p > > > > that allows to configure the keyboard illumination on Dell syst= ems. > > > >=20 > > > > Signed-off-by: Gabriele Mazzotta > > > > Signed-off-by: Pali Roh=E1r > > > > --- > > > > .../ABI/testing/sysfs-platform-dell-laptop | 60 ++++++= ++++++++++++++++ > > > > 1 file changed, 60 insertions(+) > > > > create mode 100644 Documentation/ABI/testing/sysfs-platform-de= ll-laptop > > > >=20 > > > > diff --git a/Documentation/ABI/testing/sysfs-platform-dell-lapt= op b/Documentation/ABI/testing/sysfs-platform-dell-laptop > > > > new file mode 100644 > > > > index 0000000..7969443 > > > > --- /dev/null > > > > +++ b/Documentation/ABI/testing/sysfs-platform-dell-laptop > > > > @@ -0,0 +1,60 @@ > > > > +What: /sys/class/leds/dell::kbd_backlight/als_setting > > > > +Date: December 2014 > > > > +KernelVersion: 3.19 > > > > +Contact: Gabriele Mazzotta , > > > > + Pali Roh=E1r > > > > +Description: > > > > + This file allows to control the automatic keyboard > > > > + illumination mode on some systems that have an ambient > > > > + light sensor. Write 1 to this file to enable the auto > > > > + mode, 0 to disable it. > > > [...] > > >=20 > > > This entry appears wrong, or at least incomplete. My system boots= with a > > > default value of 18, and the 'set' implementation accepts any val= ue from > > > 0 to 255. > > >=20 > > > According to the comments in dell-laptop.c, the value actually me= ans > > > something different than on/off: > > >=20 > > > cbArg3, byte0 Desired setting of ALS value that turns the ligh= t on or off. > > >=20 > > > Admittedly, I'm not clear on what the intended interface is, as I= 've > > > never had the ALS / keyboard backlight controls all working prope= rly on > > > my laptop in the first place, but I thought this would be the rig= ht > > > place to ask about getting the documentation and driver in sync. > >=20 > > Hi, > >=20 > > You are perfectly right, the documentation is wrong and I'm sorry f= or > > that. als_setting should allow you to define when the keyboard > > backlight has to be turned on or off depending on the value reporte= d > > by the ambient light sensor. > >=20 > > Please note that not everything that is in libsmbios [1] is impleme= nted > > in the kernel driver. Take a look at it, recently there have been f= ew > > changes related to the ALS settings. Probably they are not needed g= iven > > that you are able to set the threshold with the current kernel driv= er, > > but you might find something interesting. > >=20 > > I'll submit a patch to correct the documentation, thanks for report= ing. >=20 > Hi Gabriele, >=20 > Have I missed a patch from you for this? I'd like to see this correct= ed in the > 3.19 rc cycle. >=20 > Thanks, I'm sorry, I must have done something wrong when I sent the patch, the CC list is not complete. Thanks for the link Brian.