From: Elizabeth Figura <zfigura@codeweavers.com>
To: dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
Mike Lothian <mike@fireburn.co.uk>
Cc: "Mike Lothian" <mike@fireburn.co.uk>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
wine-devel@winehq.org, "André Almeida" <andrealmeid@igalia.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Arkadiusz Hiler" <ahiler@codeweavers.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Boqun Feng" <boqun.feng@gmail.com>
Subject: Re: [PATCH] ntsync: Set the permissions to be 0666
Date: Tue, 18 Feb 2025 17:57:31 -0600 [thread overview]
Message-ID: <2768333.mvXUDI8C0e@camazotz> (raw)
In-Reply-To: <20250214122759.2629-2-mike@fireburn.co.uk>
On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote:
> This allows ntsync to be usuable by non-root processes out of the box
>
> Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
> ---
> drivers/misc/ntsync.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> index 055395cde42b..586b86243e1d 100644
> --- a/drivers/misc/ntsync.c
> +++ b/drivers/misc/ntsync.c
> @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = {
> .minor = MISC_DYNAMIC_MINOR,
> .name = NTSYNC_NAME,
> .fops = &ntsync_fops,
> + .mode = 0666, // Setting file permissions to 0666
> };
>
> module_misc_device(ntsync_misc);
>
Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>
--
The comment seems rather redundant, but otherwise this is correct and prudent.
next prev parent reply other threads:[~2025-02-18 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 12:28 [PATCH] ntsync: Set the permissions to be 0666 Mike Lothian
2025-02-14 13:06 ` Greg Kroah-Hartman
2025-02-14 18:13 ` Elizabeth Figura
2025-02-14 18:45 ` Darrick J. Wong
2025-02-14 22:15 ` Elizabeth Figura
2025-02-15 1:03 ` Darrick J. Wong
2025-02-15 1:24 ` Elizabeth Figura
2025-02-15 5:59 ` Greg Kroah-Hartman
2025-02-18 23:57 ` Elizabeth Figura [this message]
2025-02-19 14:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2768333.mvXUDI8C0e@camazotz \
--to=zfigura@codeweavers.com \
--cc=ahiler@codeweavers.com \
--cc=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=luto@kernel.org \
--cc=mike@fireburn.co.uk \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=wine-devel@winehq.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).