From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26671A8F6D; Tue, 18 Feb 2025 23:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=4.36.192.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739923068; cv=none; b=VDEqFzcfKYpuRypPbbkq18WgCyM2PFS3FS+yKUrLPwDDkx7mc3D0oN4M6dBars3PZLL60KbfTotMU0o6QTIuz2EGlh1ajUCKizYKy9XoIwJOWKr51PnvDOLPeF/4wVIJ8rPhZ5BoYHwDyccuKuns/GvDfbtdWDBGQTtF8fYFk2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739923068; c=relaxed/simple; bh=e9Scv+eAu9ME6/BW8di5Qlh9xBT/ZlYHOwKeekqAKEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZTVWvqJt166/ou8BdUOYQoycT5XVmmdkSs3GxdqurnPz/L0cfcuc5/y1lT3fKZe91Z3zNfokIOsXA8nGL0Xq9dy/xHAepbwJGpnZnMmAWqqrpMSDeGAqrjpannPrAFUS8xhwx2xNDtmUqvfiVdoBdZuuK7QElvS5/juqCn5TfIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeweavers.com; spf=pass smtp.mailfrom=codeweavers.com; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b=beFRfKIp; arc=none smtp.client-ip=4.36.192.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="beFRfKIp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=s1; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=f8V96M1dNZ/nDV9/9O0iW1J6fywepGaauBM99maMCPQ=; b=beFRfKIpyWei/AqaxjdVB1+t7R myVQ+O8u5GMBnjskUEmNlLfY2k+BjDYJ7w99yJukhUdZfNzVclUJYwTLt5ozKiqSyOnHHHUVnuATY s1PkyXMVtxNW1TaPbjkZ7DWF4CxFIQbBMieRn4zalDn8sDu321MTv6bk3r3O1ywLLMeFLEpXnYKrG g0KSQUirG3qstUAAXwr96d6E0RHjQojV8gp5Q58FIJ8fmjeY7HPsF+jufg2LFkgsHb/eMw1QZGMZm cObsCE9Uhe9+0UvFvVbB4PY8Y951NMvQIwx7/K41+Nd03w3YYn1vWo0cWFSBd0wgUwS7s1L3i7MLO wgotkd9g==; Received: from cw137ip160.mn.codeweavers.com ([10.69.137.160] helo=camazotz.localnet) by mail.codeweavers.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tkXT1-00Agzb-2A; Tue, 18 Feb 2025 17:57:31 -0600 From: Elizabeth Figura To: dri-devel@lists.freedesktop.org, Arnd Bergmann , Greg Kroah-Hartman , Jonathan Corbet , Shuah Khan , Mike Lothian Cc: Mike Lothian , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, wine-devel@winehq.org, =?UTF-8?B?QW5kcsOp?= Almeida , Wolfram Sang , Arkadiusz Hiler , Peter Zijlstra , Andy Lutomirski , Randy Dunlap , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng Subject: Re: [PATCH] ntsync: Set the permissions to be 0666 Date: Tue, 18 Feb 2025 17:57:31 -0600 Message-ID: <2768333.mvXUDI8C0e@camazotz> In-Reply-To: <20250214122759.2629-2-mike@fireburn.co.uk> References: <20250214122759.2629-2-mike@fireburn.co.uk> Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Friday, 14 February 2025 06:28:00 CST Mike Lothian wrote: > This allows ntsync to be usuable by non-root processes out of the box > > Signed-off-by: Mike Lothian > --- > drivers/misc/ntsync.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c > index 055395cde42b..586b86243e1d 100644 > --- a/drivers/misc/ntsync.c > +++ b/drivers/misc/ntsync.c > @@ -1208,6 +1208,7 @@ static struct miscdevice ntsync_misc = { > .minor = MISC_DYNAMIC_MINOR, > .name = NTSYNC_NAME, > .fops = &ntsync_fops, > + .mode = 0666, // Setting file permissions to 0666 > }; > > module_misc_device(ntsync_misc); > Reviewed-by: Elizabeth Figura -- The comment seems rather redundant, but otherwise this is correct and prudent.