From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D59C433DB for ; Sun, 28 Mar 2021 20:55:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B082061927 for ; Sun, 28 Mar 2021 20:55:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbhC1Uyn (ORCPT ); Sun, 28 Mar 2021 16:54:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbhC1UyM (ORCPT ); Sun, 28 Mar 2021 16:54:12 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F615C0613B1 for ; Sun, 28 Mar 2021 13:54:11 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id o16so10875880wrn.0 for ; Sun, 28 Mar 2021 13:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uUUE0tRysCl/AZmYpBE7nB+xaBTY+Blnl2TRorK4CnE=; b=K/gEePEDOzCnjIelkn1fH5ent6cwQvRSdL9xWz2JB4u9smCm8AgkmljP8Nt2AIQMzz UTJyQzBCSOQN5aWJaaM55iUE1zdr8cxuD05IjrYdn5sC01T7yZ2MnLTpPFDavu46vBHr qG3yqCsa9ldF/lZYyhqvj3xipK/Db4AgEx6rUJW0wFqrYYnC1j+BqSXBNJk/g3OC3lwl 5aP1RiKSBqiwaWCDkDBsQqiQhSXyvHV6z79L+xGyRmjxmxQbJKxQfUioGMg5i4n27Hca BI6kKvsxDdSEgzQCuBnekyoiLeOfv6dD58KiiyQGvHgWdsLe2xN6wlpRk1RKWuRXzGt6 ol5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uUUE0tRysCl/AZmYpBE7nB+xaBTY+Blnl2TRorK4CnE=; b=LTRMlhSfe465hhVfT0Eu75TNQcIi2sEqP7zMt0h19ye5zlRcVYaktvbThbO2/mqn5i Tk7K+oZVWWt/eykZxbj0GOK4kX/suBtHLGLOzWJcUtOOd1xiLej5L3fCWhmigt2AqgNf qflCwFlwn9mO1u0X5vx3TA1Nn01/rfkCIcX7ibnfM22vIUEvmLtH2d02cDs/DxkEFTjR 9t5ARATpMt1L3beEt7mRSq5a0CEJUsbEaG/7JoSrpugLJyHqjmi7ofOw3C6MjDRt6oc/ WBQXDRgkUC45QG9z0M1YnbgblEzse4z9jjaej2vZpFGZR1eqKFg2Q0x6N86UAtR8R0sj MpEw== X-Gm-Message-State: AOAM533sa4luxsgfrH6DiiZmm493ecHELSSTsJZwRdKQWe53zfwH80xh XPJE9r/tGOLKzBhyT83Uq6ED1aiQRvhY4g== X-Google-Smtp-Source: ABdhPJw/+473E5al27E6cQcqeHyl/jgUQtowDCwkSE4Ne4syo7zVokG2CEjHrtXgV/DHDlUKpZ/eKA== X-Received: by 2002:adf:d4ca:: with SMTP id w10mr26144466wrk.146.1616964849655; Sun, 28 Mar 2021 13:54:09 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:1945:696f:a453:cac9? ([2a01:e34:ed2f:f020:1945:696f:a453:cac9]) by smtp.googlemail.com with ESMTPSA id p14sm21920580wmc.30.2021.03.28.13.54.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Mar 2021 13:54:09 -0700 (PDT) Subject: Re: [PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point To: Srinivas Pandruvada , "Rafael J. Wysocki" Cc: rkumbako@quicinc.com, Zhang Rui , Amit Kucheria , "open list:THERMAL" , open list , "open list:ABI/API" References: <20210325193633.19592-1-daniel.lezcano@linaro.org> <444a7fc72e6525575b929760fcad186630577afc.camel@linux.intel.com> From: Daniel Lezcano Message-ID: <2fa60fba-e904-62c1-9b9c-9e05a877c050@linaro.org> Date: Sun, 28 Mar 2021 22:54:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On 28/03/2021 21:31, Srinivas Pandruvada wrote: > Hi Daniel, [ ... ] >> I don't see where is the problem. The protocol is still compatible >> with >> the previous version, so that does not break the existing AFAICT. >> That >> is done on purpose. > > The size of netlink message is changed. This is not a good argument to > just adding members at the end. The point I am trying that netlink now > is an ABI, which should go through same process as we are > adding/changing a sysfs attributes. > Ok I understand your point. I will provide a description in Documentation/ABI/testing, something I should have done before and take the opportunity to provide a bigger update of the thermal netlink messages with more commands. Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog