linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: herbert@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org
Subject: [PATCH v2 1/5] MPI: fix off by one in mpi_read_raw_from_sgl
Date: Sun, 18 Oct 2015 12:45:18 +0200	[thread overview]
Message-ID: <3192672.E3TvJmsW94@myon.chronox.de> (raw)
In-Reply-To: <1831785.BBs8Hj3CxY@myon.chronox.de>

The patch fixes the analysis of the input data which contains an off
by one.

The issue is visible when the SGL contains one byte per SG entry.
The code for checking for zero bytes does not operate on the data byte.

Signed-off-by: Stephan Mueller <smueller@chronox.de>
---
 lib/mpi/mpicoder.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index c20ef27..c7e0a70 100644
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -446,8 +446,11 @@ MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int len)
 		const u8 *buff = sg_virt(sg);
 		int len = sg->length;
 
-		while (len-- && !*buff++)
+		while (len && !*buff) {
 			lzeros++;
+			len--;
+			buff++;
+		}
 
 		if (len && *buff)
 			break;
-- 
2.5.0

  reply	other threads:[~2015-10-18 10:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 10:44 [PATCH v2 0/5] crypto: add algif_akcipher user space API Stephan Mueller
2015-10-18 10:45 ` Stephan Mueller [this message]
2015-10-19 23:25   ` [PATCH v2 1/5] MPI: fix off by one in mpi_read_raw_from_sgl Tadeusz Struk
     [not found]   ` <3192672.E3TvJmsW94-Veo+UhszpQh6vwJ5+F2VIg@public.gmane.org>
2015-10-20 14:20     ` Herbert Xu
2015-10-18 10:46 ` [PATCH v2 2/5] crypto: AF_ALG -- add sign/verify API Stephan Mueller
2015-10-18 10:47 ` [PATCH v2 3/5] crypto: AF_ALG -- add setpubkey setsockopt call Stephan Mueller
     [not found]   ` <1500043.fUe7nt4IEH-Veo+UhszpQh6vwJ5+F2VIg@public.gmane.org>
2015-10-30  8:16     ` Marcel Holtmann
2015-10-30  8:42       ` Stephan Mueller
2015-10-18 10:48 ` [PATCH v2 4/5] crypto: AF_ALG -- add asymmetric cipher interface Stephan Mueller
2015-10-18 10:49 ` [PATCH v2 5/5] crypto: algif_akcipher - enable compilation Stephan Mueller
     [not found] ` <1831785.BBs8Hj3CxY-Veo+UhszpQh6vwJ5+F2VIg@public.gmane.org>
2015-10-19  1:32   ` [PATCH v2 0/5] crypto: add algif_akcipher user space API Herbert Xu
2015-10-19  7:14     ` Stephan Mueller
2015-10-19  7:27       ` Herbert Xu
2015-10-27  4:54 ` Marcel Holtmann
     [not found]   ` <BDD3AC1F-26D5-41D2-863B-CF8C7BF5FFEE-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2015-10-27  9:12     ` Stephan Mueller
     [not found]       ` <1979544.kURdYDnObN-gNvIQDDl/k7Ia13z/PHSgg@public.gmane.org>
2015-10-27  9:19         ` David Woodhouse
     [not found]           ` <1445937541.3405.75.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-27 10:50             ` Stephan Mueller
2015-10-27 23:15               ` David Woodhouse
2015-10-27 23:35                 ` Stephan Mueller
     [not found]                   ` <1499937.MpmApGzYrd-gNvIQDDl/k7Ia13z/PHSgg@public.gmane.org>
2015-10-27 23:43                     ` David Woodhouse
     [not found]                       ` <1445989396.3405.131.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-27 23:47                         ` Stephan Mueller
2015-10-28  0:37                           ` David Woodhouse
     [not found]                             ` <1445992622.3405.148.camel-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-10-28  1:18                               ` Stephan Mueller
     [not found]                                 ` <2035809.AHCPW286O9-Veo+UhszpQh6vwJ5+F2VIg@public.gmane.org>
2015-10-28  1:36                                   ` David Woodhouse
2015-10-28  0:46                           ` Marcel Holtmann
2015-10-28  1:29                             ` Stephan Mueller
2015-10-28  2:56                               ` Marcel Holtmann
     [not found]                                 ` <F0D283A6-37C8-47EC-9DE0-998B8A59F138-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2015-10-28 10:12                                   ` Stephan Mueller
2015-10-27 15:16     ` Tadeusz Struk
2015-12-14 18:06     ` Tadeusz Struk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3192672.E3TvJmsW94@myon.chronox.de \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).