* [PATCH] ipc: Fix building compat mode without sysvipc
@ 2019-03-06 14:29 Arnd Bergmann
2019-03-06 14:44 ` Laura Abbott
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2019-03-06 14:29 UTC (permalink / raw)
To: y2038
Cc: Arnd Bergmann, Laura Abbott, John Stultz, Thomas Gleixner,
Dominik Brodowski, linux-api, linux-kernel
As John Stultz noticed, my y2038 syscall series caused a link
failure when CONFIG_SYSVIPC is enabled but CONFIG_COMPAT is
enabled:
arch/arm64/kernel/sys32.o:(.rodata+0x960): undefined reference to `__arm64_compat_sys_old_semctl'
arch/arm64/kernel/sys32.o:(.rodata+0x980): undefined reference to `__arm64_compat_sys_old_msgctl'
arch/arm64/kernel/sys32.o:(.rodata+0x9a0): undefined reference to `__arm64_compat_sys_old_shmctl'
Add the missing entries in kernel/sys_ni.c for the new system
calls.
Cc: Laura Abbott <labbott@redhat.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I'm about to send off my pull requests for arm-soc, so I'd just
send another one with just this common from my y2038 tree.
---
kernel/sys_ni.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
index 85e5ccec0955..62a6c8707799 100644
--- a/kernel/sys_ni.c
+++ b/kernel/sys_ni.c
@@ -202,6 +202,7 @@ COND_SYSCALL(msgget);
COND_SYSCALL(old_msgctl);
COND_SYSCALL(msgctl);
COND_SYSCALL_COMPAT(msgctl);
+COND_SYSCALL_COMPAT(old_msgctl);
COND_SYSCALL(msgrcv);
COND_SYSCALL_COMPAT(msgrcv);
COND_SYSCALL(msgsnd);
@@ -212,6 +213,7 @@ COND_SYSCALL(semget);
COND_SYSCALL(old_semctl);
COND_SYSCALL(semctl);
COND_SYSCALL_COMPAT(semctl);
+COND_SYSCALL_COMPAT(old_semctl);
COND_SYSCALL(semtimedop);
COND_SYSCALL(semtimedop_time32);
COND_SYSCALL(semop);
@@ -221,6 +223,7 @@ COND_SYSCALL(shmget);
COND_SYSCALL(old_shmctl);
COND_SYSCALL(shmctl);
COND_SYSCALL_COMPAT(shmctl);
+COND_SYSCALL_COMPAT(old_shmctl);
COND_SYSCALL(shmat);
COND_SYSCALL_COMPAT(shmat);
COND_SYSCALL(shmdt);
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipc: Fix building compat mode without sysvipc
2019-03-06 14:29 [PATCH] ipc: Fix building compat mode without sysvipc Arnd Bergmann
@ 2019-03-06 14:44 ` Laura Abbott
2019-03-06 15:00 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Laura Abbott @ 2019-03-06 14:44 UTC (permalink / raw)
To: Arnd Bergmann, y2038
Cc: John Stultz, Thomas Gleixner, Dominik Brodowski, linux-api,
linux-kernel
On 3/6/19 6:29 AM, Arnd Bergmann wrote:
> As John Stultz noticed, my y2038 syscall series caused a link
> failure when CONFIG_SYSVIPC is enabled but CONFIG_COMPAT is
> enabled:
>
is this supposed to be "CONFIG_SYSVIPC is disabled" to match the
subject?
> arch/arm64/kernel/sys32.o:(.rodata+0x960): undefined reference to `__arm64_compat_sys_old_semctl'
> arch/arm64/kernel/sys32.o:(.rodata+0x980): undefined reference to `__arm64_compat_sys_old_msgctl'
> arch/arm64/kernel/sys32.o:(.rodata+0x9a0): undefined reference to `__arm64_compat_sys_old_shmctl'
>
> Add the missing entries in kernel/sys_ni.c for the new system
> calls.
>
> Cc: Laura Abbott <labbott@redhat.com>
> Cc: John Stultz <john.stultz@linaro.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I'm about to send off my pull requests for arm-soc, so I'd just
> send another one with just this common from my y2038 tree.
> ---
> kernel/sys_ni.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index 85e5ccec0955..62a6c8707799 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -202,6 +202,7 @@ COND_SYSCALL(msgget);
> COND_SYSCALL(old_msgctl);
> COND_SYSCALL(msgctl);
> COND_SYSCALL_COMPAT(msgctl);
> +COND_SYSCALL_COMPAT(old_msgctl);
> COND_SYSCALL(msgrcv);
> COND_SYSCALL_COMPAT(msgrcv);
> COND_SYSCALL(msgsnd);
> @@ -212,6 +213,7 @@ COND_SYSCALL(semget);
> COND_SYSCALL(old_semctl);
> COND_SYSCALL(semctl);
> COND_SYSCALL_COMPAT(semctl);
> +COND_SYSCALL_COMPAT(old_semctl);
> COND_SYSCALL(semtimedop);
> COND_SYSCALL(semtimedop_time32);
> COND_SYSCALL(semop);
> @@ -221,6 +223,7 @@ COND_SYSCALL(shmget);
> COND_SYSCALL(old_shmctl);
> COND_SYSCALL(shmctl);
> COND_SYSCALL_COMPAT(shmctl);
> +COND_SYSCALL_COMPAT(old_shmctl);
> COND_SYSCALL(shmat);
> COND_SYSCALL_COMPAT(shmat);
> COND_SYSCALL(shmdt);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipc: Fix building compat mode without sysvipc
2019-03-06 14:44 ` Laura Abbott
@ 2019-03-06 15:00 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-03-06 15:00 UTC (permalink / raw)
To: Laura Abbott
Cc: y2038 Mailman List, John Stultz, Thomas Gleixner,
Dominik Brodowski, Linux API, Linux Kernel Mailing List
On Wed, Mar 6, 2019 at 3:44 PM Laura Abbott <labbott@redhat.com> wrote:
>
> On 3/6/19 6:29 AM, Arnd Bergmann wrote:
> > As John Stultz noticed, my y2038 syscall series caused a link
> > failure when CONFIG_SYSVIPC is enabled but CONFIG_COMPAT is
> > enabled:
> >
>
> is this supposed to be "CONFIG_SYSVIPC is disabled" to match the
> subject?
Fixing it now, thanks!
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-06 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 14:29 [PATCH] ipc: Fix building compat mode without sysvipc Arnd Bergmann
2019-03-06 14:44 ` Laura Abbott
2019-03-06 15:00 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).