From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2DCC43219 for ; Thu, 5 May 2022 08:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350955AbiEEJAP (ORCPT ); Thu, 5 May 2022 05:00:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350979AbiEEJAO (ORCPT ); Thu, 5 May 2022 05:00:14 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1891A4AE22; Thu, 5 May 2022 01:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651740995; x=1683276995; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=FXK7ar2tfCe3b0G5EJOLZVnb+48+yJ1/UsODDRlXrb0=; b=TL9dK+sKuTs6J0DgMzsfeBUR4jmf6zNYt5CTNWxnsUW7Y+Yne877rIoM xUP1nsYvgGP3tnaMlTVLBkUovoj3xVSpJns89RrCfLPcbNTWj8otudnmz /R2c43hrY14NffVCxIB3folmTGOPsqhAJUFrs4IbcM/GU/ELZzMQaEUiC 078hGn7Qe+IpQLE9AimcQg7K8PHs9A6yrD42Mn+aeFpurhd7gXHNDXhYG GgAM6pnIcXlThqaMkMsvHy4mfBmSJ0uCLBohnK7aQcBmr1p1WVJJ6lM76 8vgSxRkvBMssZ+N8G8dZBfcZisHAj8tkh5AR4m9Of0shAiVvBDt5Jar7Q A==; X-IronPort-AV: E=McAfee;i="6400,9594,10337"; a="265642312" X-IronPort-AV: E=Sophos;i="5.91,200,1647327600"; d="scan'208";a="265642312" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 01:56:26 -0700 X-IronPort-AV: E=Sophos;i="5.91,200,1647327600"; d="scan'208";a="585219605" Received: from tpaatola-mobl1.ger.corp.intel.com ([10.251.220.83]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 01:56:20 -0700 Date: Thu, 5 May 2022 11:56:15 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Arnd Bergmann cc: Greg KH , linux-serial , Jiri Slaby , Linux API , Ivan Kokshaysky , Matt Turner , alpha , Thomas Bogendoerfer , "open list:BROADCOM NVRAM DRIVER" , "James E.J. Bottomley" , Helge Deller , Parisc List , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev , linux-arch , LKML Subject: Re: [PATCH 1/1] termbits: Convert octal defines to hex In-Reply-To: Message-ID: <386eed36-94f7-8acb-926f-99c74d55915f@linux.intel.com> References: <2c8c96f-a12f-aadc-18ac-34c1d371929c@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-878121235-1651740985=:1544" Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-878121235-1651740985=:1544 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 4 May 2022, Arnd Bergmann wrote: > On Wed, May 4, 2022 at 10:33 AM Ilpo Järvinen > wrote: > > On Wed, 4 May 2022, Arnd Bergmann wrote: > > > On Wed, May 4, 2022 at 9:20 AM Ilpo Järvinen wrote: > > > > > > > After applying the patch locally, I still see a bunch of whitespace > > > differences in the > > > changed lines if I run > > > > > > vimdiff arch/*/include/uapi/asm/termbits.h include/uapi/asm-generic/termbits.h > > > > > > I think this mostly because you left the sparc version alone (it already > > > uses hex constants), but it may be nice to edit this a little more to > > > make the actual differences stick out more. > > > > I took a look on further harmonizing, however, it turned out to be not > > that simple. This is basically the pipeline I use to further cleanup the > > differences and remove comments if you want to play yourself, just remove > > stages from the tail to get the intermediate datas (gawk is required for > > --non-decimal-data): > > I've played around with it some more to adjust the number of leading > zeroes and the type of whitespace. This is what I ended up with on top > of your patch: https://pastebin.com/raw/pkDPaKN1 > > Feel free to fold it into yours. Ok thanks. With that it seems to go a bit beyond octal to hex conversion so I'll make a series out of it. The series will also introduce include/uapi/asm-generic/termbits-common.h for the most obvious intersection. -- i. --8323329-878121235-1651740985=:1544--