From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC v4 02/18] bpf: Move u64_to_ptr() to BPF headers and inline it Date: Wed, 26 Oct 2016 09:19:08 +0200 Message-ID: <4045933.vGduYR3PCp@wuerfel> References: <20161026065654.19166-1-mic@digikod.net> <20161026065654.19166-3-mic@digikod.net> Reply-To: kernel-hardening@lists.openwall.com Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: <20161026065654.19166-3-mic@digikod.net> To: =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov , Andy Lutomirski , Daniel Borkmann , Daniel Mack , David Drysdale , "David S . Miller" , "Eric W . Biederman" , James Morris , Jann Horn , Kees Cook , Paul Moore , Sargun Dhillon , "Serge E . Hallyn" , Tejun Heo , Thomas Graf , Will Drewry , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, cgroups@vger.kernel.org List-Id: linux-api@vger.kernel.org On Wednesday, October 26, 2016 8:56:38 AM CEST Micka=EBl Sala=FCn wrote: > include/linux/bpf.h | 6 ++++++ > kernel/bpf/syscall.c | 6 ------ > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/include/linux/bpf.h b/include/linux/bpf.h > index c201017b5730..cf87db6daf27 100644 > --- a/include/linux/bpf.h > +++ b/include/linux/bpf.h > @@ -283,6 +283,12 @@ static inline void bpf_long_memcpy(void *dst, const = void *src, u32 size) > =20 > /* verify correctness of eBPF program */ > int bpf_check(struct bpf_prog **fp, union bpf_attr *attr); > + > +/* helper to convert user pointers passed inside __aligned_u64 fields */ > +static inline void __user *u64_to_ptr(__u64 val) > +{ > + return (void __user *) (unsigned long) val; > +} > #else >=20 We already have at least six copies of this helper: fs/btrfs/qgroup.c:#define u64_to_ptr(x) ((struct btrfs_qgroup *)(uintptr_t)= x) kernel/bpf/syscall.c:static void __user *u64_to_ptr(__u64 val) drivers/staging/android/ion/ion_test.c:#define u64_to_uptr(x) ((void __user= *)(unsigned long)(x)) drivers/firewire/core-cdev.c:static void __user *u64_to_uptr(u64 value) drivers/staging/android/ion/ion_test.c:#define u64_to_uptr(x) ((void __user= *)(unsigned long)(x)) include/linux/kernel.h:#define u64_to_user_ptr(x) ( \ Just use the one in linux/kernel.h Arnd