From: Laurent Vivier <laurent@vivier.eu>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: YunQiang Su <syq@debian.org>,
torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
James.Bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
libc-alpha@sourceware.org
Subject: Re: [PATCH] binfmt_misc: pass binfmt_misc P flag to the interpreter
Date: Fri, 6 Mar 2020 12:13:41 +0100 [thread overview]
Message-ID: <40da389d-4e74-2644-2e7c-04d988fcc26f@vivier.eu> (raw)
In-Reply-To: <87mu8t3mlw.fsf@mid.deneb.enyo.de>
Le 06/03/2020 à 09:37, Florian Weimer a écrit :
> * Laurent Vivier:
>
>> Le 06/03/2020 à 09:13, Florian Weimer a écrit :
>>> * YunQiang Su:
>>>
>>>> + if (bprm->interp_flags & BINPRM_FLAGS_PRESERVE_ARGV0)
>>>> + flags |= AT_FLAGS_PRESERVE_ARGV0;
>>>> + NEW_AUX_ENT(AT_FLAGS, flags);
>>>
>>> Is it necessary to reuse AT_FLAGS? I think it's cleaner to define a
>>> separate AT_ tag dedicated to binfmt_misc.
>>
>> Not necessary, but it seemed simpler and cleaner to re-use a flag that
>> is marked as unused and with a name matching the new role. It avoids to
>> patch other packages (like glibc) to add it as it is already defined.
>
> You still need to define AT_FLAGS_PRESERVE_ARGV0. At that point, you
> might as well define AT_BINFMT and AT_BINFMT_PRESERVE_ARGV0.
>
Yes, you're right.
But is there any reason to not reuse AT_FLAGS?
Thanks,
Laurent
next prev parent reply other threads:[~2020-03-06 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 8:09 [PATCH] binfmt_misc: pass binfmt_misc P flag to the interpreter YunQiang Su
2020-03-06 8:13 ` Florian Weimer
2020-03-06 8:21 ` Laurent Vivier
2020-03-06 8:37 ` Florian Weimer
2020-03-06 11:13 ` Laurent Vivier [this message]
2020-03-06 11:29 ` YunQiang Su
2020-03-06 11:40 ` Florian Weimer
2020-03-06 11:48 ` YunQiang Su
2020-03-06 12:07 ` Florian Weimer
2020-03-06 12:07 ` Laurent Vivier
2020-03-11 9:09 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40da389d-4e74-2644-2e7c-04d988fcc26f@vivier.eu \
--to=laurent@vivier.eu \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=fw@deneb.enyo.de \
--cc=gregkh@linuxfoundation.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syq@debian.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).