From: Elizabeth Figura <zfigura@codeweavers.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
wine-devel@winehq.org, "André Almeida" <andrealmeid@igalia.com>,
"Wolfram Sang" <wsa@kernel.org>,
"Arkadiusz Hiler" <ahiler@codeweavers.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Andy Lutomirski" <luto@kernel.org>,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Randy Dunlap" <rdunlap@infradead.org>
Subject: Re: [PATCH v2 04/31] ntsync: Introduce NTSYNC_IOC_WAIT_ANY.
Date: Mon, 11 Mar 2024 13:58:18 -0500 [thread overview]
Message-ID: <4875514.GXAFRqVoOG@camazotz> (raw)
In-Reply-To: <20240219223833.95710-5-zfigura@codeweavers.com>
On Monday, 19 February 2024 16:38:06 CDT Elizabeth Figura wrote:
> +static struct ntsync_obj *get_obj(struct ntsync_device *dev, int fd)
> +{
> + struct file *file = fget(fd);
> + struct ntsync_obj *obj;
> +
> + if (file->f_op != &ntsync_obj_fops) {
> + fput(file);
> + return NULL;
> + }
I just noticed during self-review that this fails to check the result of
fget() for NULL :-/
I'll fix this next revision.
> +
> + obj = file->private_data;
> + if (obj->dev != dev) {
> + fput(file);
> + return NULL;
> + }
> +
> + return obj;
> +}
next prev parent reply other threads:[~2024-03-11 19:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 22:38 [PATCH v2 00/31] NT synchronization primitive driver Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 01/31] ntsync: Introduce the ntsync driver and character device Elizabeth Figura
2024-02-22 10:56 ` Geert Uytterhoeven
2024-02-22 20:13 ` Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM Elizabeth Figura
2024-03-07 22:12 ` Greg Kroah-Hartman
2024-02-19 22:38 ` [PATCH v2 03/31] ntsync: Introduce NTSYNC_IOC_SEM_POST Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 04/31] ntsync: Introduce NTSYNC_IOC_WAIT_ANY Elizabeth Figura
2024-03-11 18:58 ` Elizabeth Figura [this message]
2024-02-19 22:38 ` [PATCH v2 05/31] ntsync: Introduce NTSYNC_IOC_WAIT_ALL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 06/31] ntsync: Introduce NTSYNC_IOC_CREATE_MUTEX Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 07/31] ntsync: Introduce NTSYNC_IOC_MUTEX_UNLOCK Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 08/31] ntsync: Introduce NTSYNC_IOC_MUTEX_KILL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 09/31] ntsync: Introduce NTSYNC_IOC_CREATE_EVENT Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 10/31] ntsync: Introduce NTSYNC_IOC_EVENT_SET Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 11/31] ntsync: Introduce NTSYNC_IOC_EVENT_RESET Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 12/31] ntsync: Introduce NTSYNC_IOC_EVENT_PULSE Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 13/31] ntsync: Introduce NTSYNC_IOC_SEM_READ Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 14/31] ntsync: Introduce NTSYNC_IOC_MUTEX_READ Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 15/31] ntsync: Introduce NTSYNC_IOC_EVENT_READ Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 16/31] ntsync: Introduce alertable waits Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 17/31] ntsync: Allow waits to use the REALTIME clock Elizabeth Figura
2024-02-20 7:01 ` Arnd Bergmann
2024-02-22 0:48 ` Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 18/31] selftests: ntsync: Add some tests for semaphore state Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 19/31] selftests: ntsync: Add some tests for mutex state Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 20/31] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ANY Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 21/31] selftests: ntsync: Add some tests for NTSYNC_IOC_WAIT_ALL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 22/31] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ANY Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 23/31] selftests: ntsync: Add some tests for wakeup signaling with WINESYNC_IOC_WAIT_ALL Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 24/31] selftests: ntsync: Add some tests for manual-reset event state Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 25/31] selftests: ntsync: Add some tests for auto-reset " Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 26/31] selftests: ntsync: Add some tests for wakeup signaling with events Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 27/31] selftests: ntsync: Add tests for alertable waits Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 28/31] selftests: ntsync: Add some tests for wakeup signaling via alerts Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 29/31] selftests: ntsync: Add a stress test for contended waits Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 30/31] maintainers: Add an entry for ntsync Elizabeth Figura
2024-02-19 22:38 ` [PATCH v2 31/31] docs: ntsync: Add documentation for the ntsync uAPI Elizabeth Figura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4875514.GXAFRqVoOG@camazotz \
--to=zfigura@codeweavers.com \
--cc=ahiler@codeweavers.com \
--cc=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=shuah@kernel.org \
--cc=wine-devel@winehq.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).