From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>, linux-man@vger.kernel.org
Cc: mtk.manpages@gmail.com, jstancek@redhat.com, mszeredi@redhat.com,
linux-api@vger.kernel.org, chrubis@suse.cz, tytso@mit.edu,
bfields@fieldses.org, pgajdos@suse.com,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH] utimensat: immutable flag returns -EPERM
Date: Tue, 14 Apr 2020 11:25:45 +0200 [thread overview]
Message-ID: <48ae74c5-29ca-aa71-4618-7f25e12d544f@gmail.com> (raw)
In-Reply-To: <20170605141827.21420-1-rgoldwyn@suse.de>
Hello Goldwyn,
On 6/5/17 4:18 PM, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> Linux kernel commit 337684a1746f "fs: return EPERM on immutable inode"
> changed (nd unified the return value of the utimensat(2) from -EACCES
> to -EPERM in case of an immutable flag. Modify the man page to
> reflect the same.
>
> The entire discussion of returning the correct return value is at:
> http://lists.linux.it/pipermail/ltp/2017-January/003424.html
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Thanks. Patch (finally) applied.
Cheers,
Michael
> ---
> man2/utimensat.2 | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/man2/utimensat.2 b/man2/utimensat.2
> index f77d0b42a..c0bdf8808 100644
> --- a/man2/utimensat.2
> +++ b/man2/utimensat.2
> @@ -238,10 +238,7 @@ or both
> .I tv_nsec
> values are
> .BR UTIME_NOW ,
> -and either:
> -.RS
> -.IP * 3
> -the effective user ID of the caller does not match
> +and the effective user ID of the caller does not match
> the owner of the file,
> the caller does not have write access to the file,
> and the caller is not privileged
> @@ -249,7 +246,7 @@ and the caller is not privileged
> .B CAP_FOWNER
> or the
> .B CAP_DAC_OVERRIDE
> -capability); or,
> +capability).
> .\" But Linux 2.6.22 was broken here.
> .\" Traditionally, utime()/utimes() gives the error EACCES for the case
> .\" where the timestamp pointer argument is NULL (i.e., set both timestamps
> @@ -271,9 +268,6 @@ capability); or,
> .\" and the permissions of the directory to which
> .\" .I fd
> .\" refers do not allow searches.
> -.IP *
> -the file is marked immutable (see
> -.BR chattr (1)).
> .\" EXT2_IMMUTABLE_FL and similar flags for other filesystems.
> .RE
> .TP
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2020-04-14 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 14:18 [PATCH] utimensat: immutable flag returns -EPERM Goldwyn Rodrigues
2020-04-14 9:25 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ae74c5-29ca-aa71-4618-7f25e12d544f@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=bfields@fieldses.org \
--cc=chrubis@suse.cz \
--cc=jstancek@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=pgajdos@suse.com \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).