linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	arnd-r2nGTMty4D4@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	mingo-X9Un+BFzKDI@public.gmane.org,
	ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org
Subject: Re: + preadv-pwritev-add-preadv-and-pwritev-system-calls.patch added to -mm tree
Date: Tue, 03 Feb 2009 11:14:28 +0100	[thread overview]
Message-ID: <49881904.30705@redhat.com> (raw)
In-Reply-To: <49876A91.4000705-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>

H. Peter Anvin wrote:
> akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org wrote:
>>
>> This prototype has one problem though: On 32bit archs is the (64bit)
>> offset argument unaligned, which the syscall ABI of several archs doesn't
>> allow to do.  At least s390 needs a wrapper in glibc to handle this.  As
>> we'll need a wrappers in glibc anyway I've decided to push problem to
>> glibc entriely and use a syscall prototype which works without
>> arch-specific wrappers inside the kernel: The offset argument is
>> explicitly splitted into two 32bit values.
> 
> That rather sucks.  It'd be cleaner to just shuffle the argument order.

That was discussed too.  Doesn't solve the problem that you need some
wrap-o-magic in glibc (this time to swap arguments instead of splitting
the offset).  And is has the drawback that it is confusing to have
different argument ordering at application and syscall level (think
strace).  Check the archives for the details.

cheers,
  Gerd

--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-02-03 10:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-02 21:35 + preadv-pwritev-add-preadv-and-pwritev-system-calls.patch added to -mm tree akpm
     [not found] ` <200902022135.n12LZa1a010673-AB4EexQrvXRQetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2009-02-02 21:50   ` H. Peter Anvin
     [not found]     ` <49876A91.4000705-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-02-03 10:14       ` Gerd Hoffmann [this message]
     [not found]         ` <49881904.30705-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-02-03 17:06           ` H. Peter Anvin
     [not found]             ` <498879B3.8030002-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-02-03 17:15               ` Russell King
     [not found]                 ` <20090203171559.GA20898-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2009-02-03 17:29                   ` H. Peter Anvin
     [not found]                     ` <49887EF4.1090300-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2009-02-03 17:42                       ` Russell King
2009-02-03 20:19                         ` H. Peter Anvin
2009-02-05  0:42                         ` H. Peter Anvin
2009-02-02 21:51 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49881904.30705@redhat.com \
    --to=kraxel-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mingo-X9Un+BFzKDI@public.gmane.org \
    --cc=mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).