From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C6411DF754 for ; Mon, 21 Oct 2024 16:44:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729529053; cv=none; b=nxSXn6toK9NYIHm2fJE/XLgh6LWR/rMvkIpt449a1mvF5IxKt0pDEezTjf7oOdqnQO3+/ujPdNOWK9DxBR0apJCQcO99pDhcrICQfsZ3IZ/8ETdpvdSilVvwvQRJofKjxYM+EYs6ablPYGV4W+IrbsuvTY0ZQDfoKX4yxq6U2qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729529053; c=relaxed/simple; bh=90WzKZzAZAmAVCyRIe7kK7DX/+sIoDuVHi8ZMPTCuuY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TtPhr02yBjvZhEmBYIefWc9LWNlIRNmf7OPMI7NrEDQ2cwbDdZ08ln5OyIa//b5m5mQl5Md9DJFf5gq+UfbRQeSe4QDhd0xH989cisSy6oSAHyQ5IWNbz0aiX1OU25QThIYwagSlm2mUD5UE/6vN6HswoZV6eZABN998mHP78t8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q9Iom4vS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q9Iom4vS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729529050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZX/Ilyoxcq0UVbahtd/J3opNKl8Rn4eQwpxqo4bqGEg=; b=Q9Iom4vS9Iwopaiq0rIFIjssNP6pfQHJew1TZLa3WzarYqDpNbbf9bFucvjQt4fn9Fl7DM A2OQvXFLIns23ogtwh/QLiNZR+blDljaBVym9pRIVR7pad8qAtXFjWIhXlk5Z4Hc/RWLRR O5QKAa8lgeZJ1k+TVJbcyVK9SPr8knw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-383--YyH75HoMU2r8HuQfEOFqw-1; Mon, 21 Oct 2024 12:44:09 -0400 X-MC-Unique: -YyH75HoMU2r8HuQfEOFqw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4316e2dde9eso17737995e9.2 for ; Mon, 21 Oct 2024 09:44:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729529048; x=1730133848; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZX/Ilyoxcq0UVbahtd/J3opNKl8Rn4eQwpxqo4bqGEg=; b=icg+zY/EBK95ExXY1diPBqms5uL1sCkVJldb3L1bNBS/W66gkPXWOAcK+PB0yxKsZm OEkDlBcwpZOvZaC3EnBdCvCljE2sMBd0Q8pRbbb1qfg71QDm7USmh/IzzgxN+Pp2THlS QjSgMZA40Qg2TA9E8RIb7STyJnJ6+Dha3HCE6uqp5jT6T29YyNU+ZNQsYYGFqZpG07e4 JBY2sAwlzZFlsRDS85bL7TbYj444rS2gQEM62Q9DTOoz6TDP+TdByF9pbtYEsDUZeKRL /BPwR1htbFEJXvJf0H03+ove/bkk89TLf8pEgIyHBcu5Xu7cCb/abPRFvtbB2lk5Biq9 eR5g== X-Forwarded-Encrypted: i=1; AJvYcCVkuXyQCkBQHFGA8BW4Jq5Ar/6VBT/Ci68lYhKU7HcExeDa/vogcgLc25Cq3DHHfIR2EGbJrShhu2E=@vger.kernel.org X-Gm-Message-State: AOJu0YwDNdr4ICdbkGQSDXHVgATv58BK/vD8SBrhGZxy4qZD2qCrn20B ben6JMqQNzm5cbRSgX2ntRGbs8Mwu3OWrAqGlmglOhUN6bFrxUc2/1/nvaGUUPbrB6Ge6JZ2+En WZr+LnfRYg1kdquYVh+1cqt3fEMckkn0P6TkYS6xnrUyXAnLbRDlU3ACazQ== X-Received: by 2002:a7b:c2aa:0:b0:42f:75e0:780e with SMTP id 5b1f17b1804b1-43161627e30mr128257665e9.10.1729529047767; Mon, 21 Oct 2024 09:44:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5GC3sMvDU9EM77w02UBxgdwq7oI8saD249CUHCeGMLn1ysjfgnLo9K0fi+joG4IN/csYJDQ== X-Received: by 2002:a7b:c2aa:0:b0:42f:75e0:780e with SMTP id 5b1f17b1804b1-43161627e30mr128257295e9.10.1729529047326; Mon, 21 Oct 2024 09:44:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c728:1600:e899:f836:758b:6fef? (p200300cbc7281600e899f836758b6fef.dip0.t-ipconnect.de. [2003:cb:c728:1600:e899:f836:758b:6fef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431605f81a2sm125944225e9.0.2024.10.21.09.44.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2024 09:44:06 -0700 (PDT) Message-ID: <49afa956-21e1-4b3d-9dde-82a6891f2902@redhat.com> Date: Mon, 21 Oct 2024 18:44:04 +0200 Precedence: bulk X-Mailing-List: linux-api@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] mm: add PTE_MARKER_GUARD PTE marker To: Lorenzo Stoakes Cc: Vlastimil Babka , Andrew Morton , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , "Paul E . McKenney" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Chris Zankel , Max Filippov , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, Shuah Khan , Christian Brauner , linux-kselftest@vger.kernel.org, Sidhartha Kumar , Jeff Xu , Christoph Hellwig , linux-api@vger.kernel.org, John Hubbard References: <081837b697a98c7fa5832542b20f603d49e0b557.1729440856.git.lorenzo.stoakes@oracle.com> <470886d2-9f6f-4486-a935-daea4c5bea09@suse.cz> <434a440a-d6a4-4144-b4fb-8e0d8535f03f@lucifer.local> <4f4e41f1-531c-4686-b44d-dacdf034c241@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21.10.24 18:23, Lorenzo Stoakes wrote: > On Mon, Oct 21, 2024 at 06:00:20PM +0200, David Hildenbrand wrote: > [snip] >>> >>> To summarise for on-list: >>> >>> * MADV_FREE, while ostensibly being a 'lazy free' mechanism, has the >>> ability to be 'cancelled' if you write to the memory. Also, after the >>> freeing is complete, you can write to the memory to reuse it, the mapping >>> is still there. >>> >>> * For hardware poison markers it makes sense to drop them as you're >>> effectively saying 'I am done with this range that is now unbacked and >>> expect to get an empty page should I use it now'. UFFD WP I am not sure >>> about but presumably also fine. >>> >>> * However, guard pages are different - if you 'cancel' and you are left >>> with a block of memory allocated to you by a pthread or userland >>> allocator implementation, you don't want to then no longer be protected >>> from overrunning into other thread memory. >> >> Agreed. What happens on MADV_DONTNEED/MADV_FREE on guard pages? Ignored or >> error? It sounds like a usage "error" to me (in contrast to munmap()). > > It's ignored, no errror. On MADV_DONTNEED we already left the guard pages in > place, from v3 we will do the same for MADV_FREE. > > I'm not sure I'd say it's an error per se, as somebody might have a use case > where they want to zap over a range but keep guard pages, perhaps an allocator > or something? Hm, not sure I see use for that. Staring at madvise_walk_vmas(), we return ENOMEM on VMA holes, but would process PROT_NONE. So current behavior is at least consistent with PROT_NONE handling (where something could be mapped, though). No strong opinion. > > Also the existing logic is that existing markers (HW poison, uffd-simulated HW > poison, uffd wp marker) are retained and no error raised on MADV_DONTNEED, and > no error on MADV_FREE either, so it'd be consistent with existing behaviour. HW poison / uffd-simulated HW poison are expected to be zapped: it's just like a mapped page with HWPOISON. So that is correct. UFFD-WP behavior is ... weird. Would not expect MADV_DONTNEED to zap uffd-wp entries. > > Also semantically you are achieving what the calls expect you are freeing the > ranges since the guard page regions are unbacked so are already freed... so yeah > I don't think an error really makes sense here. I you compare it to a VMA hole, it make sense to fail. If we treat it like PROT_NONE, it make sense to skip them. > > We might also be limiting use cases by assuming they might _only_ be used for > allocators and such. I don't buy that as an argument, sorry :) "Let's map the kernel writable into all user space because otherwise we might be limiting use cases" :P -- Cheers, David / dhildenb