From: <Hermes.Wu@ite.com.tw>
To: <hverkuil+cisco@kernel.org>, <mchehab@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>
Cc: <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <broonie@kernel.org>,
<lgirdwood@gmail.com>, <linux-sound@vger.kernel.org>,
<linux-api@vger.kernel.org>
Subject: RE: [PATCH 2/5] media: Documentation: it6625: document the audio controls
Date: Wed, 18 Nov 2026 05:05:32 +0000 [thread overview]
Message-ID: <4b85b91fba654ab18c2d5afd1820e473@ite.com.tw> (raw)
In-Reply-To: <a554e557-3d10-465e-ad3b-90d8357b60f2@kernel.org>
Hi Hans,
On 11/11/2026 13:12, Hans Verkuil wrote:
> We need to make standard controls for the audio sampling rate and presence.
> They are also used by the tc358743 driver, and are in fact common for all
> HDMI receiver drivers (I know of a bunch of out-of-tree drivers that use the
> same controls).
>
> So rather than creating driver-specific controls, can you add standard
> controls for this? They belong to the V4L2_CID_DV_CLASS control class.
>
> So the defines become:
>
> V4L2_CID_DV_RX_AUDIO_SAMPLING_RATE and V4L2_CID_DV_RX_AUDIO_PRESENT.
Thanks for the review. I will add the two standard controls and send
v2 in this order:
1. v4l2-ctrls: add V4L2_CID_DV_RX_AUDIO_SAMPLING_RATE and
V4L2_CID_DV_RX_AUDIO_PRESENT (read-only; the rate as an integer in
Hz, 0 when there is no audio or the rate is unknown; present as a
boolean), with their documentation in ext-ctrls-dv.rst.
2. tc358743: set the standard controls in addition to its custom ones.
3. The IT6625 patches, using the standard controls. The it6625.rst
patch is dropped.
Should the tc358743 change go in the same series, or would you prefer
it sent separately?
One question about IT6625 itself. Its two driver-specific controls,
V4L2_CID_IT6625_AUDIO_SAMPLING_RATE and V4L2_CID_IT6625_AUDIO_PRESENT,
are not new in this series. They came with the driver itself, commit
142e5f00bd57 ("media: i2c: add driver for ITE IT6625/IT6626"), which is
in media next and in v7.4-rc1 but not yet in a released kernel. This
audio series only documents them. Which do you prefer:
a) keep them and also set the standard controls, as for tc358743; or
b) remove them with a fix for v7.4, before they end up in a release,
so that IT6625 only has the standard controls?
About your comment on patch 5/5 (the audio type control as a standard
DV control): the value IT6625 reports there is the type of the HDMI
audio stream as the bridge firmware classifies it (LPCM, compressed,
HBR or one-bit), not the codec. It is not always exact: the firmware
also reports HBR for some compressed streams at ordinary rates, such as
48 kHz DTS. I would propose a read-only menu control:
V4L2_CID_DV_RX_AUDIO_TYPE
V4L2_DV_RX_AUDIO_TYPE_LPCM linear PCM (audio sample packets)
V4L2_DV_RX_AUDIO_TYPE_IEC61937 compressed audio, IEC 61937
V4L2_DV_RX_AUDIO_TYPE_HBR high bit rate audio packets
V4L2_DV_RX_AUDIO_TYPE_ONE_BIT one-bit (DSD) audio packets
The codec of a compressed stream (AC-3, DTS, ...) is not reported by
the bridge; userspace finds it in the IEC 61937 data. Does that fit
what you had in mind, or should the control describe something else?
Best regards,
Hermes
next prev parent reply other threads:[~2026-11-18 5:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 6:50 [PATCH 0/5] media: i2c: it6625: add HDMI audio capture over I2S Hermes Wu via B4 Relay
2026-11-03 6:50 ` [PATCH 1/5] dt-bindings: media: ite,it6625: add audio DAI properties Hermes Wu via B4 Relay
2026-11-04 14:24 ` Krzysztof Kozlowski
2026-11-05 1:50 ` Hermes.Wu
2026-11-03 6:50 ` [PATCH 2/5] media: Documentation: it6625: document the audio controls Hermes Wu via B4 Relay
2026-11-11 12:12 ` Hans Verkuil
2026-11-18 5:05 ` Hermes.Wu [this message]
2026-11-03 6:50 ` [PATCH 3/5] media: i2c: it6625: decode audio status fields with FIELD_GET() Hermes Wu via B4 Relay
2026-11-03 6:50 ` [PATCH 4/5] media: i2c: it6625: add I2S audio capture DAI Hermes Wu via B4 Relay
2026-11-03 6:50 ` [PATCH 5/5] media: i2c: it6625: capture compressed and HBR audio, not just LPCM Hermes Wu via B4 Relay
2026-11-11 12:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b85b91fba654ab18c2d5afd1820e473@ite.com.tw \
--to=hermes.wu@ite.com.tw \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox