From: "Michael Kerrisk" <mtk.manpages@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>,
subrata@linux.vnet.ibm.com, linux-arch@vger.kernel.org,
drepper@redhat.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, linux-api@vger.kernel.org,
linux-man@vger.kernel.org, davidel@xmailserver.org,
netdev@vger.kernel.org, roland@redhat.com, oleg@tv-sign.ru,
hch@lst.de, davem@davemloft.net, alan@redhat.com,
jakub@redhat.com
Subject: Re: [PATCH] reintroduce accept4
Date: Fri, 14 Nov 2008 10:24:22 -0500 [thread overview]
Message-ID: <517f3f820811140724l49dd0f31xffda837afd1986a8@mail.gmail.com> (raw)
In-Reply-To: <20081113145737.96898aaf.akpm@linux-foundation.org>
Andrew,
> From: Ulrich Drepper <drepper@redhat.com>
>
> Introduce a new accept4() system call. The addition of this system call
> matches analogous changes in 2.6.27 (dup3(), evenfd2(), signalfd4(),
> inotify_init1(), epoll_create1(), pipe2()) which added new system calls
> that differed from analogous traditional system calls in adding a flags
> argument that can be used to access additional functionality.
>
> The accept4() system call is exactly the same as accept(), except that it
> adds a flags bit-mask argument. Two flags are initially implemented.
> (Most of the new system calls in 2.6.27 also had both of these flags.)
Add a para break here.
> SOCK_CLOEXEC causes the close-on-exec (FD_CLOEXEC) flag to be enabled for
> the new file descriptor returned by accept4(). This is a useful security
> feature to avoid leaking information in a multithreaded program where one
> thread is doing an accept() at the same time as another thread is doing a
> fork() plus exec().
>
This para break is in the wrong place.
> More details here: http://udrepper.livejournal.com/20407.html "Secure File
> Descriptor Handling", Ulrich Drepper) The other flag is SOCK_NONBLOCK,
The para break should actually be at the sentence break in the previous line.
Cheers,
Michael
next prev parent reply other threads:[~2008-11-14 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200810261641.m9QGfotr024285@hs20-bc2-1.build.redhat.com>
[not found] ` <200810261641.m9QGfotr024285-sQhldQRnEDHy+ZiRM8QlFPXAX3CI6PSWQQ4Iyu8u01E@public.gmane.org>
2008-10-28 3:41 ` [PATCH] reintroduce accept4 Andrew Morton
[not found] ` <20081027204135.a139704e.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-10-28 4:22 ` Ulrich Drepper
[not found] ` <490693A3.9070805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-28 4:52 ` Andrew Morton
2008-10-28 12:34 ` Michael Kerrisk
2008-11-13 21:51 ` Michael Kerrisk
[not found] ` <517f3f820811131351l1305b2d2u43ab4e0601d97f93-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-13 22:02 ` Michael Kerrisk
[not found] ` <cfd18e0f0811131402j7ec6a60cq462916cc9715b9aa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-13 22:11 ` Michael Kerrisk
[not found] ` <cfd18e0f0811131411o5b47175dl36b022bc762181e5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-11-13 22:14 ` Michael Kerrisk
2008-11-13 22:05 ` Andrew Morton
2008-11-13 22:25 ` Paul Mackerras
[not found] ` <18716.43376.534965.688695-UYQwCShxghk5kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
2008-11-13 22:28 ` Paul Mackerras
[not found] ` <18716.43543.256621.825529-UYQwCShxghk5kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
2008-11-13 22:57 ` Andrew Morton
[not found] ` <20081113145737.96898aaf.akpm@linux-foundation.org>
[not found] ` <20081113145737.96898aaf.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-11-14 0:07 ` David Miller
2008-11-14 15:24 ` Michael Kerrisk [this message]
2008-11-14 17:40 ` Michael Kerrisk
[not found] ` <20081113140541.23754cad.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-11-14 15:24 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517f3f820811140724l49dd0f31xffda837afd1986a8@mail.gmail.com \
--to=mtk.manpages@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=davem@davemloft.net \
--cc=davidel@xmailserver.org \
--cc=drepper@redhat.com \
--cc=hch@lst.de \
--cc=jakub@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=paulus@samba.org \
--cc=roland@redhat.com \
--cc=subrata@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).