From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH 1/1] posix-timers: Show clock ID in proc file Date: Fri, 17 May 2013 20:12:55 +0400 Message-ID: <51965707.5010305@parallels.com> References: <1368742323-46949-1-git-send-email-snorcht@gmail.com> <1368742323-46949-2-git-send-email-snorcht@gmail.com> <20130517155916.GA24976@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130517155916.GA24976@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: Pavel Tikhomirov , Thomas Gleixner , Ingo Molnar , Michael Kerrisk , Matthew Helsley , linux-api@vger.kernel.org, Linux Kernel Mailing List List-Id: linux-api@vger.kernel.org On 05/17/2013 07:59 PM, Greg KH wrote: > On Fri, May 17, 2013 at 02:12:03AM +0400, Pavel Tikhomirov wrote: >> Expand information about posix-timers in /proc//timers by adding >> info about clock, with which the timer was created. I.e. in the forth >> line of timer info after "notify:" line go "ClockID: ". >> >> Signed-off-by: Pavel Tikhomirov >> --- >> fs/proc/base.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/proc/base.c b/fs/proc/base.c >> index 2dad4a9..8a38eef 100644 >> --- a/fs/proc/base.c >> +++ b/fs/proc/base.c >> @@ -2079,6 +2079,7 @@ static int show_timer(struct seq_file *m, void *v) >> nstr[notify & ~SIGEV_THREAD_ID], >> (notify & SIGEV_THREAD_ID) ? "tid" : "pid", >> pid_nr_ns(timer->it_pid, tp->ns)); >> + seq_printf(m, "ClockID: %d\n", timer->it_clock); > > What userspace tool just broke by adding a new field to this file? Zero for two reasons: 1. this proc file appeared this merge window 2. this file format is : and should be parsed line-by-line by applications like e.g. /proc/pid/status or /proc/pid/smaps. Both these files were extended with fields in the past with no worries to tools, so should be this new one. > thanks, > > greg k-h > . > Thanks, Pavel