From: Arnd Bergmann <arnd@arndb.de>
To: Shaohua Li <shli@fb.com>
Cc: linux-mm@kvack.org, linux-api@vger.kernel.org,
Kernel-team@fb.com, Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Minchan Kim <minchan@kernel.org>
Subject: Re: [PATCH V3][for-next] mm: add a new vector based madvise syscall
Date: Tue, 08 Dec 2015 22:37:47 +0100 [thread overview]
Message-ID: <5198777.4WMnOS8J5R@wuerfel> (raw)
In-Reply-To: <7c6ce0f1fe29fc22faf72134f4e2674da8d3d149.1449532062.git.shli@fb.com>
On Monday 07 December 2015 15:54:07 Shaohua Li wrote:
> index dc1040a..08466c7 100644
> --- a/arch/x86/entry/syscalls/syscall_64.tbl
> +++ b/arch/x86/entry/syscalls/syscall_64.tbl
> @@ -333,6 +333,7 @@
> 324 common membarrier sys_membarrier
> 325 common mlock2 sys_mlock2
> 326 common copy_file_range sys_copy_file_range
> +327 common madvisev sys_madvisev
>
> #
> # x32-specific system call numbers start at 512 to avoid cache impact
>
An iovec has different sizes on 32-bit and 64-bit user space, so I think
it can't be marked "common" here and you need to implement a
compat_sys_madvisev function instead.
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-12-08 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 23:54 [PATCH V3][for-next] mm: add a new vector based madvise syscall Shaohua Li
[not found] ` <7c6ce0f1fe29fc22faf72134f4e2674da8d3d149.1449532062.git.shli-b10kYP2dOMg@public.gmane.org>
2015-12-08 6:18 ` Andi Kleen
2015-12-08 17:38 ` Shaohua Li
2015-12-08 21:37 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5198777.4WMnOS8J5R@wuerfel \
--to=arnd@arndb.de \
--cc=Kernel-team@fb.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).