From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH 11/11] ext4: add cross rename support Date: Wed, 23 Apr 2014 21:01:16 +0200 Message-ID: <53580DFC.9060507@gmail.com> References: <1389219015-10980-1-git-send-email-miklos@szeredi.hu> <1389219015-10980-12-git-send-email-miklos@szeredi.hu> <20140113122517.GA10366@quack.suse.cz> <20140115182347.GB5715@fieldses.org> <20140116105406.GF24171@tucsk.piliscsaba.szeredi.hu> <52D90B93.5010209@gmail.com> <20140117144126.GG24171@tucsk.piliscsaba.szeredi.hu> <53523D16.9020101@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Miklos Szeredi Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, "J. Bruce Fields" , Jan Kara , Al Viro , Linus Torvalds , Linux-Fsdevel , Kernel Mailing List , Christoph Hellwig , Andrew Morton , David Howells , Zach Brown , Andy Lutomirski , "mszeredi-AlSwsSmVLrQ@public.gmane.org" , "linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux API , Carlos O'Donell List-Id: linux-api@vger.kernel.org On 04/23/2014 04:21 PM, Miklos Szeredi wrote: > On Sat, Apr 19, 2014 at 11:08 AM, Michael Kerrisk (man-pages) > wrote: >> Hi Miklos, >> >>> The code changes are pushed to the git tree and the updated man page is below. >> >> Now that renameat2() is in 3.15, I've taken these changes. This had to be >> manually does, because I'd done some major reworking on the pages since you >> originally wrote your text. So, I may have injected some errors. >> >> I did a little light reworking of the text and added VERSIONS and >> CONFORMING TO pieces. I also added a couple of FIXMEs, to note points >> that will need to be updated once glibc support is (presumably) added. >> (Carlos, what's the usual process for triggering that sort of thing?) >> >> Could you please review the diff below (now against rename(2)). > > Looks okay. Thanks for checking it. > One comment on the current rename.2 page: > > #include /* Definition of AT_* constants */ > > AT_ constants are not used in renameat() hence this seems unneeded. I think you overlooked AT_FDCWD? (It is true though that that comment is boilerplate across the *at() pages, some of which have several AT_* constants.) > Not sure where the RENAME_ constants need to go once renameat2() is > added to glibc, possibly to since they are closely related > to rename. Will you be prodding the glibc folks about this? Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html