Re: [PATCH v2 5/7] selftests/mount: change test to use ksft framework

Eric W. Biederman
2014-09-23T23:07:28Z

Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> writes:

> On 09/23/2014 04:41 PM, Eric W. Biederman wrote:
>> Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> writes:
>>
>>> Change mount test to use kselftest framework to report
>>> test results.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
>>
>> I am curious did you even run these tests? I can't possibly see how
>> the tests would have passed with this change. At the very least you
>> have taken this test from linear to exponential time complexity.
>>
>
> Oops. I meant to drop this commit from the series. Sorry for the
> noise.

No problem. Except for the unnecessary semantic change the rest of the
change looked fine. I just wanted to make certain you didn't break my
test by accident.

Eric