From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Berger Subject: Re: [tpmdd-devel] [PATCH v7 04/10] tpm: rename chip->dev to chip->pdev Date: Tue, 25 Nov 2014 16:44:53 -0500 Message-ID: <5474F855.7080207@linux.vnet.ibm.com> References: <1415713513-16524-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1415713513-16524-5-git-send-email-jarkko.sakkinen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415713513-16524-5-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jarkko Sakkinen , Peter Huewe , Ashley Lai , Marcel Selhorst Cc: christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, josh.triplett-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org, trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-api@vger.kernel.org On 11/11/2014 08:45 AM, Jarkko Sakkinen wrote: > Rename chip->dev to chip->pdev to make it explicit that this not the > character device but actually represents the platform device. > > Signed-off-by: Jarkko Sakkinen > > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h > index 69f4003..b3a7c76 100644 > --- a/drivers/char/tpm/tpm.h > +++ b/drivers/char/tpm/tpm.h > @@ -98,7 +98,7 @@ struct tpm_vendor_specific { > #define TPM_PPI_VERSION_LEN 3 > > struct tpm_chip { > - struct device *dev; /* Device stuff */ > + struct device *pdev; /* Device stuff */ > const struct tpm_class_ops *ops; > > int dev_num; /* /dev/tpm# */ So this is the core requiring the renamings. I assume you got them all and none were hidden in #if's or so. Reviewed-by: Stefan Berger